[GitHub] [hudi] nsivabalan commented on pull request #5350: [HUDI-3884] Adding support to let archival proceed beyond savepointed commits

[GitBox <gi...@apache.org>]

nsivabalan commented on PR #5350:
URL: https://github.com/apache/hudi/pull/5350#issuecomment-1101907596

   yes. While loading file groups, we deduce whether a commit is valid or not based on below logic 
   ```
     /**
      * A FileSlice is considered committed, if one of the following is true - There is a committed data file - There are
      * some log files, that are based off a commit or delta commit.
      */
     private boolean isFileSliceCommitted(FileSlice slice) {
       String maxCommitTime = lastInstant.get().getTimestamp();
       return timeline.containsOrBeforeTimelineStarts(slice.getBaseInstantTime())
           && HoodieTimeline.compareTimestamps(slice.getBaseInstantTime(), HoodieTimeline.LESSER_THAN_OR_EQUALS, maxCommitTime);
     }
   ```
   
   So, after first entry in active timeline, there are no holes expected. May be there are other places where we make such assumptions. So, reverting the patch to WIP for now as this needs some more investigation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org