[jira] [Commented] (HIVE-1953) Hive should process comments in CliDriver

["jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087600#comment-13087600 ] 

jiraposter@reviews.apache.org commented on HIVE-1953:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1587/
-----------------------------------------------------------

Review request for hive and Yongqiang He.


Summary
-------

skip comments in cliDriver.main() instead of passing down to command processors.


This addresses bug HIVE-1953.
    https://issues.apache.org/jira/browse/HIVE-1953


Diffs
-----

  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java a2976b5 

Diff: https://reviews.apache.org/r/1587/diff


Testing
-------

tested build, since the test suite goes through driver, adding a query file test case did not work.


Thanks,

Syed



> Hive should process comments in CliDriver
> -----------------------------------------
>
>                 Key: HIVE-1953
>                 URL: https://issues.apache.org/jira/browse/HIVE-1953
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Syed S. Albiz
>         Attachments: HIVE-1953.1.patch
>
>
> If you put commend before a set command, it will faile. 
> Like this:
> -- TestSerDe is a user defined serde where the default delimiter is Ctrl-B
> -- the user is overwriting it with ctrlC
> set hive.input.format=org.apache.hadoop.hive.ql.io.HiveInputFormat;
> Hive should process the comment in CliDriver, and ignore the comment right away, instead of passing it to the downstream processors.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira