You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Magrath <gi...@git.apache.org> on 2015/03/05 12:32:20 UTC

[GitHub] thrift pull request: THRIFT-3023 Only make variable Go safe if we ...

GitHub user Magrath opened a pull request:

    https://github.com/apache/thrift/pull/389

    THRIFT-3023 Only make variable Go safe if we aren't publicising it

    Publicising it will make it safe as all reserved keywords are lowercase so there is no need to execute variable_name_to_go_name if the output will then be passed to publicize.
    
    https://issues.apache.org/jira/browse/THRIFT-3023

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Magrath/thrift THRIFT-3023

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #389
    
----
commit e9a79f80e717d2beda65a2aae3709372d8618ec6
Author: Paul Magrath <pa...@swiftkey.com>
Date:   2015-03-05T11:29:21Z

    THRIFT-3023 Only make variable Go safe if we aren't publicising it (publicising it will make it safe as all reserved keywords are lowercase)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---