[GitHub] [tvm] mehrdadh commented on a diff in pull request #10945: [Hexagon] Handle TCP server binding to unknown port

[GitBox <gi...@apache.org>]

mehrdadh commented on code in PR #10945:
URL: https://github.com/apache/tvm/pull/10945#discussion_r847505527


##########
python/tvm/contrib/hexagon/build.py:
##########
@@ -110,6 +110,7 @@ def __init__(self, rpc_info: dict, workspace: Union[str, pathlib.Path] = None):
         }
         self._rpc_info.update(rpc_info)
         self._workspace = self._create_workspace(workspace)
+        self._device_key = self.HEXAGON_REMOTE_DEVICE_KEY

Review Comment:
   wouldn't this always set the key to be `self.HEXAGON_REMOTE_DEVICE_KEY`? My understanding is that the goal is to be able to set the `key` to distinguish RPC server between different tests/runs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org