[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections and callQueueLen directly in HBaseServer

["Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195395#comment-13195395 ] 

Zhihong Yu commented on HBASE-5297:
-----------------------------------

I think RpcServer.java might have been dropped from the patch.
That's why I got the following compilation error:
{code}
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile (default-compile) on project hbase: Compilation failure
[ERROR] /Users/zhihyu/trunk-hbase/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java:[250,16] org.apache.hadoop.hbase.ipc.WritableRpcEngine.Server is not abstract and does not override abstract method getCallQueueLen() in org.apache.hadoop.hbase.ipc.RpcServer
{code}
                
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5297
>                 URL: https://issues.apache.org/jira/browse/HBASE-5297
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>         Attachments: HBASE-5297.D1509.1.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics doesn't have to hold reference to HBaseServer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira