[GitHub] [avro] andrewthauer edited a comment on pull request #918: AVRO-2677: Fully and correctly support decimal logical type in Ruby

[GitBox <gi...@apache.org>]

andrewthauer edited a comment on pull request #918:
URL: https://github.com/apache/avro/pull/918#issuecomment-775165482


   @tjwp - Thank you!
   
   > @andrewthauer I thought it might be easier to adding the matching logic to support schema compatibility in a separate change so I've done that here: #1082
   
   So does this essentially means your PR covers any additional required code changes beyond what is in place in this PR?
   
   >  the JIRA issue (https://issues.apache.org/jira/browse/AVRO-2677) referenced by this PR is for a closed issue for the serialization of decimal logical type attributes. This PR should have a separate issue that describes what it addresses.
   
   We can go ahead and create a new JIRA issue describing the issue and what the PR solves
   
   > there is no Ruby support at all yet for _fixed_ decimal logical type which make the "fully" part of the description of this change misleading
   
   I think we will need to raise a new PR anyways, so we can adjust the title. Can you clarify what you meant by `_fixed_` decimal logical type? here?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org