You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/17 13:03:15 UTC
[GitHub] [flink] oikomi opened a new pull request #13177: [FLINK-18958] Lose column comment when create table
oikomi opened a new pull request #13177:
URL: https://github.com/apache/flink/pull/13177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "adce333a95ea3e35456433d343424300aedcb5f2",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675812346",
"triggerType" : "MANUAL"
}, {
"hash" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5696",
"triggerID" : "675836053",
"triggerType" : "MANUAL"
}, {
"hash" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5696",
"triggerID" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "675836053",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1db995acea1f9f0f9a929dd59603b44b2786c325 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5696)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] oikomi commented on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
oikomi commented on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-676945243
@wuchong OK , let's wait for FLINK-17793 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b238cb28c05a047f2d559bfe583b8562392ba563 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "adce333a95ea3e35456433d343424300aedcb5f2",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675812346",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* adce333a95ea3e35456433d343424300aedcb5f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "adce333a95ea3e35456433d343424300aedcb5f2",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675812346",
"triggerType" : "MANUAL"
}, {
"hash" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "675836053",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "675836053",
"triggerType" : "MANUAL"
}, {
"hash" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 1db995acea1f9f0f9a929dd59603b44b2786c325 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
wuchong edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-675840028
Thanks for the contribution @oikomi , after going through it roughly, I have some concern that we are making the `TableSchema` fatter and fatter. The community had some discussion to introduce a `CatalogTableSchema` to preserve the metadata information of catalog table and keep TableSchema clean to describe a schema (see FLINK-17793). Obviously, the column comment should belong to `CatalogTableSchema`.
So I'm hesitated whether we should wait for FLINK-17793 or update `TableSchema` further.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] oikomi commented on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
oikomi commented on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-675404118
hi @fsk119 I have commited a UT for colum comment and I have found a bug when not use blink planner, thank you very much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "adce333a95ea3e35456433d343424300aedcb5f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* adce333a95ea3e35456433d343424300aedcb5f2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "adce333a95ea3e35456433d343424300aedcb5f2",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675812346",
"triggerType" : "MANUAL"
}, {
"hash" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5696",
"triggerID" : "675836053",
"triggerType" : "MANUAL"
}, {
"hash" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5696",
"triggerID" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "675836053",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1db995acea1f9f0f9a929dd59603b44b2786c325 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5696)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "adce333a95ea3e35456433d343424300aedcb5f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* adce333a95ea3e35456433d343424300aedcb5f2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b238cb28c05a047f2d559bfe583b8562392ba563 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674869627
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b238cb28c05a047f2d559bfe583b8562392ba563 (Mon Aug 17 13:06:15 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] oikomi commented on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
oikomi commented on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-675836053
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
fsk119 commented on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-675286771
@oikomi Thanks for your contribution. But could you offer some test cases to verify your work? I think you should offer tests that when users use describe instruction, they can also have information about column comments. You can take a look at org.apache.flink.table.api.batch.BatchTableEnviromentTest#testExecuteSqlWithDescribe as an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-675840028
Thanks for the contribution @oikomi , after going through it roughly, I have some concern that we are making the `TableSchema` fatter and fatter. The community had some discussion to introduce a `CatalogTableSchema` to preserve the metadata information of catalog table and keep TableSchema clean to describe a schema (see FLINK-17793).
So I'm hesitated whether we should wait for FLINK-17793 or update `TableSchema` further.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "adce333a95ea3e35456433d343424300aedcb5f2",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "675812346",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* adce333a95ea3e35456433d343424300aedcb5f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b238cb28c05a047f2d559bfe583b8562392ba563 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "adce333a95ea3e35456433d343424300aedcb5f2",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* adce333a95ea3e35456433d343424300aedcb5f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-674873978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5612",
"triggerID" : "b238cb28c05a047f2d559bfe583b8562392ba563",
"triggerType" : "PUSH"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "adce333a95ea3e35456433d343424300aedcb5f2",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "675404343",
"triggerType" : "MANUAL"
}, {
"hash" : "adce333a95ea3e35456433d343424300aedcb5f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5675",
"triggerID" : "675812346",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "675836053",
"triggerType" : "MANUAL"
}, {
"hash" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5696",
"triggerID" : "675836053",
"triggerType" : "MANUAL"
}, {
"hash" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5696",
"triggerID" : "1db995acea1f9f0f9a929dd59603b44b2786c325",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 1db995acea1f9f0f9a929dd59603b44b2786c325 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5696)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lsyldliu commented on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
lsyldliu commented on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-675437232
@wuchong can you help review this pr when you are free？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] oikomi commented on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
oikomi commented on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-675812346
@flinkbot run travis
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] oikomi commented on pull request #13177: [FLINK-18958] Lose column comment when create table
Posted by GitBox <gi...@apache.org>.
oikomi commented on pull request #13177:
URL: https://github.com/apache/flink/pull/13177#issuecomment-675404343
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org