You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ja...@apache.org on 2013/04/06 16:48:10 UTC

svn commit: r1465254 - in /ofbiz/trunk: ./ framework/base/ framework/base/lib/scripting/ framework/base/src/org/ofbiz/base/container/ framework/base/src/org/ofbiz/base/container/groovy/

Author: jacopoc
Date: Sat Apr  6 14:48:10 2013
New Revision: 1465254

URL: http://svn.apache.org/r1465254
Log:
Removed the GroovyShellContainer, that was disabled by default for security reasons, mostly because it was based on some code distributed with unclear license terms.

Removed:
    ofbiz/trunk/framework/base/lib/scripting/jansi-1.2.1.jar
    ofbiz/trunk/framework/base/lib/scripting/jline-0.9.94.jar
    ofbiz/trunk/framework/base/src/org/ofbiz/base/container/GroovyShellContainer.java
    ofbiz/trunk/framework/base/src/org/ofbiz/base/container/groovy/
Modified:
    ofbiz/trunk/NOTICE
    ofbiz/trunk/framework/base/ofbiz-component.xml

Modified: ofbiz/trunk/NOTICE
URL: http://svn.apache.org/viewvc/ofbiz/trunk/NOTICE?rev=1465254&r1=1465253&r2=1465254&view=diff
==============================================================================
--- ofbiz/trunk/NOTICE (original)
+++ ofbiz/trunk/NOTICE Sat Apr  6 14:48:10 2013
@@ -347,12 +347,6 @@ This product includes software developed
 This product includes software developed by the Indiana University
 Extreme! Lab (http://www.extreme.indiana.edu/).
 =========================================================================
-==  jline Notice                                                       ==
-=========================================================================
-
-This product includes software developed by Marc Prud'hommeaux
-<mw...@cornell.edu>
-=========================================================================
 ==  FamFamFam Notice                                                   ==
 =========================================================================
 

Modified: ofbiz/trunk/framework/base/ofbiz-component.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/ofbiz-component.xml?rev=1465254&r1=1465253&r2=1465254&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/ofbiz-component.xml (original)
+++ ofbiz/trunk/framework/base/ofbiz-component.xml Sat Apr  6 14:48:10 2013
@@ -45,11 +45,4 @@ under the License.
         <property name="app-name" value="OFBiz"/>
     </container-->
 
-    <!-- load Groovy remote telnet server -->
-    <!-- Commented out by default for security reasons -->
-    <!-- the port below will be opened by Groovy -->
-    <!--container name="groovyshell-container" class="org.ofbiz.base.container.GroovyShellContainer">
-        <property name="telnet-port" value="9991"/>
-    </container-->
-
 </ofbiz-component>



Re: svn commit: r1465254 - in /ofbiz/trunk: ./ framework/base/ framework/base/lib/scripting/ framework/base/src/org/ofbiz/base/container/ framework/base/src/org/ofbiz/base/container/groovy/

Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
Done now:

https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Attic#OFBizAttic-GroovyShell

Jacopo

On Apr 6, 2013, at 6:37 PM, Jacques Le Roux <ja...@les7arts.com> wrote:

> Jacopo,
> 
> For this commit and when crowd will be removed, I believe we shoult put a note in the Attic page https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Attic
> 
> Thanks
> 
> Jacques
> 
> From: <ja...@apache.org>
>> Author: jacopoc
>> Date: Sat Apr  6 14:48:10 2013
>> New Revision: 1465254
>> 
>> URL: http://svn.apache.org/r1465254
>> Log:
>> Removed the GroovyShellContainer, that was disabled by default for security reasons, mostly because it was based on some code distributed with unclear license terms.
>> 
>> Removed:
>>   ofbiz/trunk/framework/base/lib/scripting/jansi-1.2.1.jar
>>   ofbiz/trunk/framework/base/lib/scripting/jline-0.9.94.jar
>>   ofbiz/trunk/framework/base/src/org/ofbiz/base/container/GroovyShellContainer.java
>>   ofbiz/trunk/framework/base/src/org/ofbiz/base/container/groovy/
>> Modified:
>>   ofbiz/trunk/NOTICE
>>   ofbiz/trunk/framework/base/ofbiz-component.xml
>> 
>> Modified: ofbiz/trunk/NOTICE
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/NOTICE?rev=1465254&r1=1465253&r2=1465254&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/NOTICE (original)
>> +++ ofbiz/trunk/NOTICE Sat Apr  6 14:48:10 2013
>> @@ -347,12 +347,6 @@ This product includes software developed
>> This product includes software developed by the Indiana University
>> Extreme! Lab (http://www.extreme.indiana.edu/).
>> =========================================================================
>> -==  jline Notice                                                       ==
>> -=========================================================================
>> -
>> -This product includes software developed by Marc Prud'hommeaux
>> -<mw...@cornell.edu>
>> -=========================================================================
>> ==  FamFamFam Notice                                                   ==
>> =========================================================================
>> 
>> 
>> Modified: ofbiz/trunk/framework/base/ofbiz-component.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/ofbiz-component.xml?rev=1465254&r1=1465253&r2=1465254&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/base/ofbiz-component.xml (original)
>> +++ ofbiz/trunk/framework/base/ofbiz-component.xml Sat Apr  6 14:48:10 2013
>> @@ -45,11 +45,4 @@ under the License.
>>        <property name="app-name" value="OFBiz"/>
>>    </container-->
>> 
>> -    <!-- load Groovy remote telnet server -->
>> -    <!-- Commented out by default for security reasons -->
>> -    <!-- the port below will be opened by Groovy -->
>> -    <!--container name="groovyshell-container" class="org.ofbiz.base.container.GroovyShellContainer">
>> -        <property name="telnet-port" value="9991"/>
>> -    </container-->
>> -
>> </ofbiz-component>
>> 
>> 


Re: svn commit: r1465254 - in /ofbiz/trunk: ./ framework/base/ framework/base/lib/scripting/ framework/base/src/org/ofbiz/base/container/ framework/base/src/org/ofbiz/base/container/groovy/

Posted by Jacques Le Roux <ja...@les7arts.com>.
Jacopo,

For this commit and when crowd will be removed, I believe we shoult put a note in the Attic page https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Attic

Thanks

Jacques

From: <ja...@apache.org>
> Author: jacopoc
> Date: Sat Apr  6 14:48:10 2013
> New Revision: 1465254
> 
> URL: http://svn.apache.org/r1465254
> Log:
> Removed the GroovyShellContainer, that was disabled by default for security reasons, mostly because it was based on some code distributed with unclear license terms.
> 
> Removed:
>    ofbiz/trunk/framework/base/lib/scripting/jansi-1.2.1.jar
>    ofbiz/trunk/framework/base/lib/scripting/jline-0.9.94.jar
>    ofbiz/trunk/framework/base/src/org/ofbiz/base/container/GroovyShellContainer.java
>    ofbiz/trunk/framework/base/src/org/ofbiz/base/container/groovy/
> Modified:
>    ofbiz/trunk/NOTICE
>    ofbiz/trunk/framework/base/ofbiz-component.xml
> 
> Modified: ofbiz/trunk/NOTICE
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/NOTICE?rev=1465254&r1=1465253&r2=1465254&view=diff
> ==============================================================================
> --- ofbiz/trunk/NOTICE (original)
> +++ ofbiz/trunk/NOTICE Sat Apr  6 14:48:10 2013
> @@ -347,12 +347,6 @@ This product includes software developed
> This product includes software developed by the Indiana University
> Extreme! Lab (http://www.extreme.indiana.edu/).
> =========================================================================
> -==  jline Notice                                                       ==
> -=========================================================================
> -
> -This product includes software developed by Marc Prud'hommeaux
> -<mw...@cornell.edu>
> -=========================================================================
> ==  FamFamFam Notice                                                   ==
> =========================================================================
> 
> 
> Modified: ofbiz/trunk/framework/base/ofbiz-component.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/ofbiz-component.xml?rev=1465254&r1=1465253&r2=1465254&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/base/ofbiz-component.xml (original)
> +++ ofbiz/trunk/framework/base/ofbiz-component.xml Sat Apr  6 14:48:10 2013
> @@ -45,11 +45,4 @@ under the License.
>         <property name="app-name" value="OFBiz"/>
>     </container-->
> 
> -    <!-- load Groovy remote telnet server -->
> -    <!-- Commented out by default for security reasons -->
> -    <!-- the port below will be opened by Groovy -->
> -    <!--container name="groovyshell-container" class="org.ofbiz.base.container.GroovyShellContainer">
> -        <property name="telnet-port" value="9991"/>
> -    </container-->
> -
> </ofbiz-component>
> 
>