You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by GitBox <gi...@apache.org> on 2019/12/20 12:07:46 UTC
[GitHub] [directory-ldap-api] solomax opened a new pull request #15:
[DIRAPI-353] automatic module names are added
solomax opened a new pull request #15: [DIRAPI-353] automatic module names are added
URL: https://github.com/apache/directory-ldap-api/pull/15
I was unable to test this due to missing release of `apacheds-test-framework`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-ldap-api] solomax commented on issue #15: [DIRAPI-353]
automatic module names are added
Posted by GitBox <gi...@apache.org>.
solomax commented on issue #15: [DIRAPI-353] automatic module names are added
URL: https://github.com/apache/directory-ldap-api/pull/15#issuecomment-567934760
Good to know :)
naming can be changed after testing with `real` java11 project containing `module-info`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-ldap-api] elecharny commented on issue #15: [DIRAPI-353]
automatic module names are added
Posted by GitBox <gi...@apache.org>.
elecharny commented on issue #15: [DIRAPI-353] automatic module names are added
URL: https://github.com/apache/directory-ldap-api/pull/15#issuecomment-567934100
Patch applied. Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-ldap-api] seelmann commented on a change in pull request
#15: [DIRAPI-353] automatic module names are added
Posted by GitBox <gi...@apache.org>.
seelmann commented on a change in pull request #15: [DIRAPI-353] automatic module names are added
URL: https://github.com/apache/directory-ldap-api/pull/15#discussion_r394137006
##########
File path: all/pom.xml
##########
@@ -126,6 +126,13 @@
</artifactSet>
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<createSourcesJar>true</createSourcesJar>
+ <transformers>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+ <manifestEntries>
+ <Automatic-Module-Name>apache.directory.ldap.api.all</Automatic-Module-Name>
Review comment:
@solomax @elecharny should't the name here (and in other poms) start with `org.` prefix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-ldap-api] elecharny commented on issue #15: [DIRAPI-353]
automatic module names are added
Posted by GitBox <gi...@apache.org>.
elecharny commented on issue #15: [DIRAPI-353] automatic module names are added
URL: https://github.com/apache/directory-ldap-api/pull/15#issuecomment-600465061
Quite likely, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-ldap-api] solomax closed pull request #15: [DIRAPI-353]
automatic module names are added
Posted by GitBox <gi...@apache.org>.
solomax closed pull request #15: [DIRAPI-353] automatic module names are added
URL: https://github.com/apache/directory-ldap-api/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-ldap-api] elecharny commented on issue #15: [DIRAPI-353]
automatic module names are added
Posted by GitBox <gi...@apache.org>.
elecharny commented on issue #15: [DIRAPI-353] automatic module names are added
URL: https://github.com/apache/directory-ldap-api/pull/15#issuecomment-600465999
I just added the 'org.' and committed the code. Thanks Stefan !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-ldap-api] solomax commented on a change in pull request
#15: [DIRAPI-353] automatic module names are added
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #15: [DIRAPI-353] automatic module names are added
URL: https://github.com/apache/directory-ldap-api/pull/15#discussion_r394152451
##########
File path: all/pom.xml
##########
@@ -126,6 +126,13 @@
</artifactSet>
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<createSourcesJar>true</createSourcesJar>
+ <transformers>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+ <manifestEntries>
+ <Automatic-Module-Name>apache.directory.ldap.api.all</Automatic-Module-Name>
Review comment:
I believe this is up to project maintainers :)))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org