You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "asafm (via GitHub)" <gi...@apache.org> on 2023/10/24 12:30:57 UTC
[PR] [fix][doc] Fix 2 subscription metric docs [pulsar-site]
asafm opened a new pull request, #721:
URL: https://github.com/apache/pulsar-site/pull/721
Fix docs for pulsar_subscription_back_log and pulsar_subscription_unacked_messages
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][doc] Fix 2 subscription metric docs [pulsar-site]
Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui merged PR #721:
URL: https://github.com/apache/pulsar-site/pull/721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][doc] Fix 2 subscription metric docs [pulsar-site]
Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on code in PR #721:
URL: https://github.com/apache/pulsar-site/pull/721#discussion_r1370092943
##########
docs/reference-metrics.md:
##########
@@ -363,11 +363,11 @@ All the subscription metrics are labeled with the following labels:
| Name | Type | Description |
|---|---|---|
-| pulsar_subscription_back_log | Gauge | The total backlog of a subscription (entries). |
+| pulsar_subscription_back_log | Gauge | The number of entries (messages/batched-messages) in unacknowledged state for a subscription |
| pulsar_subscription_back_log_no_delayed | Gauge | The backlog of a subscription that does not contain the delay messages (entries). |
| pulsar_subscription_delayed | Gauge | The total number of messages are delayed to be dispatched for a subscription (messages). |
| pulsar_subscription_msg_rate_redeliver | Gauge | The total message rate for message being redelivered (message per second). |
-| pulsar_subscription_unacked_messages | Gauge | The total number of unacknowledged messages of a subscription (messages). |
+| pulsar_subscription_unacked_messages | Gauge | The number of entries (messages/batched-messages) dispatched to consumers and are still unacknowledged |
Review Comment:
<img width="1291" alt="image" src="https://github.com/apache/pulsar-site/assets/989425/2c4eb090-9e01-4212-b2ab-daee20e7adf0">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][doc] Fix 2 subscription metric docs [pulsar-site]
Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on code in PR #721:
URL: https://github.com/apache/pulsar-site/pull/721#discussion_r1370092585
##########
docs/reference-metrics.md:
##########
@@ -363,11 +363,11 @@ All the subscription metrics are labeled with the following labels:
| Name | Type | Description |
|---|---|---|
-| pulsar_subscription_back_log | Gauge | The total backlog of a subscription (entries). |
+| pulsar_subscription_back_log | Gauge | The number of entries (messages/batched-messages) in unacknowledged state for a subscription |
Review Comment:
<img width="1339" alt="image" src="https://github.com/apache/pulsar-site/assets/989425/005acc02-91ea-4945-a6d7-fe8b825e3ecd">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][doc] Fix 2 subscription metric docs [pulsar-site]
Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on PR #721:
URL: https://github.com/apache/pulsar-site/pull/721#issuecomment-1777148306
@tisonkun Ok with you to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org