You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Clint Morgan (JIRA)" <ji...@apache.org> on 2008/06/10 21:33:45 UTC
[jira] Created: (HBASE-677) Make HTable, HRegion, HRegionServer,
HStore, and HColumnDescriptor subclassable
Make HTable, HRegion, HRegionServer, HStore, and HColumnDescriptor subclassable
-------------------------------------------------------------------------------
Key: HBASE-677
URL: https://issues.apache.org/jira/browse/HBASE-677
Project: Hadoop HBase
Issue Type: Improvement
Reporter: Clint Morgan
Assignee: Clint Morgan
Priority: Minor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-677) Make HTable, HRegion, HRegionServer,
HStore, and HColumnDescriptor subclassable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604069#action_12604069 ]
stack commented on HBASE-677:
-----------------------------
Unfortunately, this changes the serialization format. Means we need a migration script to bring over data that has been written with the the old Table descriptor. See failure in the TestMigration testcase.
> Make HTable, HRegion, HRegionServer, HStore, and HColumnDescriptor subclassable
> -------------------------------------------------------------------------------
>
> Key: HBASE-677
> URL: https://issues.apache.org/jira/browse/HBASE-677
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Clint Morgan
> Assignee: Clint Morgan
> Priority: Minor
> Attachments: hbase-677.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-677) Make HTable, HRegion, HRegionServer,
HStore, and HColumnDescriptor subclassable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604053#action_12604053 ]
stack commented on HBASE-677:
-----------------------------
Whats this about Clint?
{code}
@@ -220,9 +222,10 @@
out.writeBoolean(metaregion);
Bytes.writeByteArray(out, name);
out.writeInt(families.size());
+ Configuration conf = new HBaseConfiguration();
for(Iterator<HColumnDescriptor> it = families.values().iterator();
it.hasNext(); ) {
- it.next().write(out);
+ ObjectWritable.writeObject(out, it.next(), HColumnDescriptor.class, conf);
}
}
{code}
I'm guessing this an unintentional addition?
Otherwise, rest of patch looks fine. Let me know about above and I'll apply all but above changes.
> Make HTable, HRegion, HRegionServer, HStore, and HColumnDescriptor subclassable
> -------------------------------------------------------------------------------
>
> Key: HBASE-677
> URL: https://issues.apache.org/jira/browse/HBASE-677
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Clint Morgan
> Assignee: Clint Morgan
> Priority: Minor
> Attachments: hbase-677.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-677) Make HTable, HRegion, HRegionServer,
HStore, and HColumnDescriptor subclassable
Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604075#action_12604075 ]
Clint Morgan commented on HBASE-677:
------------------------------------
Ah.. Then lets just drop that for now.
> Make HTable, HRegion, HRegionServer, HStore, and HColumnDescriptor subclassable
> -------------------------------------------------------------------------------
>
> Key: HBASE-677
> URL: https://issues.apache.org/jira/browse/HBASE-677
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Clint Morgan
> Assignee: Clint Morgan
> Priority: Minor
> Attachments: hbase-677.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-677) Make HTable, HRegion, HRegionServer,
HStore, and HColumnDescriptor subclassable
Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Clint Morgan updated HBASE-677:
-------------------------------
Attachment: hbase-677.patch
In hbase-669 and hbase-665 I needed to subclass these things. Here are the changes I needed. This is not a complete solution, as it only exposes what I explicitly needed.
> Make HTable, HRegion, HRegionServer, HStore, and HColumnDescriptor subclassable
> -------------------------------------------------------------------------------
>
> Key: HBASE-677
> URL: https://issues.apache.org/jira/browse/HBASE-677
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Clint Morgan
> Assignee: Clint Morgan
> Priority: Minor
> Attachments: hbase-677.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-677) Make HTable, HRegion, HRegionServer,
HStore, and HColumnDescriptor subclassable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-677.
-------------------------
Resolution: Fixed
Fix Version/s: 0.2.0
I applied the patch minus the HTD changes. Thanks for the patch Clint.
> Make HTable, HRegion, HRegionServer, HStore, and HColumnDescriptor subclassable
> -------------------------------------------------------------------------------
>
> Key: HBASE-677
> URL: https://issues.apache.org/jira/browse/HBASE-677
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Clint Morgan
> Assignee: Clint Morgan
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: hbase-677.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-677) Make HTable, HRegion, HRegionServer,
HStore, and HColumnDescriptor subclassable
Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604063#action_12604063 ]
Clint Morgan commented on HBASE-677:
------------------------------------
Above is so I can subclass HColumnDescriptor, and then put the subclass instances into the families collection and have serialization work.
> Make HTable, HRegion, HRegionServer, HStore, and HColumnDescriptor subclassable
> -------------------------------------------------------------------------------
>
> Key: HBASE-677
> URL: https://issues.apache.org/jira/browse/HBASE-677
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Clint Morgan
> Assignee: Clint Morgan
> Priority: Minor
> Attachments: hbase-677.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.