You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/11/03 21:22:25 UTC
[GitHub] [incubator-pinot] jackjlli opened a new pull request #6229: Add profile release-sign-artifacts for pinot-spark-connector
jackjlli opened a new pull request #6229:
URL: https://github.com/apache/incubator-pinot/pull/6229
## Description
Currently the signature file for `pinot-connectors/pinot-spark-connector/target/pinot-spark-connector-0.6.0-javadoc.jar` is missing, because this file is overriden by `scala-maven-plugin` in `pinot-spark-connector` module, which is run right after the default gpg plugin signed the files.
This PR adds profile release-sign-artifacts for pinot-spark-connector module, so that the correct asc file could be generated after scala plugin overwrote the javadoc file.
By default this profile won't be executed, unless we need to cut a OSS release and need to run the following command to prepare the OSS release:
```
$ mvn -Darguments=-DskipTests release:prepare -Pscala-2.12,release-sign-artifacts
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6229: Add profile release-sign-artifacts for pinot-spark-connector
Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #6229:
URL: https://github.com/apache/incubator-pinot/pull/6229#discussion_r517538181
##########
File path: pinot-connectors/pinot-spark-connector/pom.xml
##########
@@ -186,6 +186,19 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>release-sign-artifacts</id>
+ <build>
+ <plugins>
+ <plugin>
+ <!-- GPG signing -->
Review comment:
Comments added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6229: Add profile release-sign-artifacts for pinot-spark-connector
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on a change in pull request #6229:
URL: https://github.com/apache/incubator-pinot/pull/6229#discussion_r517352814
##########
File path: pinot-connectors/pinot-spark-connector/pom.xml
##########
@@ -186,6 +186,19 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>release-sign-artifacts</id>
+ <build>
+ <plugins>
+ <plugin>
+ <!-- GPG signing -->
Review comment:
Please add comments here on why this is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #6229: Add profile release-sign-artifacts for pinot-spark-connector
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #6229:
URL: https://github.com/apache/incubator-pinot/pull/6229#issuecomment-721422429
Can the `scala-maven-plugin` run before the default pgp plugin signed the files?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #6229: Add profile release-sign-artifacts for pinot-spark-connector
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #6229:
URL: https://github.com/apache/incubator-pinot/pull/6229#issuecomment-721757627
@mangrrua Any insights on whether this is the right way to solve the problem, or if there is a more elegant way (that does not require explicitly calling scala `release-sign-artificats` when cutting a release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli edited a comment on pull request #6229: Add profile release-sign-artifacts for pinot-spark-connector
Posted by GitBox <gi...@apache.org>.
jackjlli edited a comment on pull request #6229:
URL: https://github.com/apache/incubator-pinot/pull/6229#issuecomment-721429629
> Can the `scala-maven-plugin` run before the default pgp plugin signed the files?
No, basically the `maven-source-plugin` and `scala-maven-plugin` respectively have their own life cycles. And the default pgp plugin is executed in the first life cycle. Without explicitly specifying the gpg/pgp plugin to the pom file, maven doesn't know whether this is the correct sequence. That's why I put the gpg plugin here right after the scala plugin. And my change will guarantee that the gpg plugin will sign the files **only once** at the end of the mvn command, so no double signing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv edited a comment on pull request #6229: Add profile release-sign-artifacts for pinot-spark-connector
Posted by GitBox <gi...@apache.org>.
mayankshriv edited a comment on pull request #6229:
URL: https://github.com/apache/incubator-pinot/pull/6229#issuecomment-721422429
Can the `scala-maven-plugin` run before the default gpg plugin signed the files?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli merged pull request #6229: Add profile release-sign-artifacts for pinot-spark-connector
Posted by GitBox <gi...@apache.org>.
jackjlli merged pull request #6229:
URL: https://github.com/apache/incubator-pinot/pull/6229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on pull request #6229: Add profile release-sign-artifacts for pinot-spark-connector
Posted by GitBox <gi...@apache.org>.
jackjlli commented on pull request #6229:
URL: https://github.com/apache/incubator-pinot/pull/6229#issuecomment-721429629
> Can the `scala-maven-plugin` run before the default pgp plugin signed the files?
No, basically the `maven-source-plugin` and `scala-maven-plugin` respectively have their own life cycles. And the default pgp plugin is executed in the first life cycle. Without explicitly specifying the gpg/pgp plugin to the pom file, maven doesn't know whether this is the correct sequence. That's why I put the gpg plugin here right after the scala plugin. And my change will guarantee that the gpg plugin will sign the files **only once** at the end of the mvn command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org