You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/02 14:22:45 UTC
[GitHub] [ozone] rakeshadr opened a new pull request #1884: HDDS-4784. TestRootedOzoneFileSystem is not picking the configured 'P…
rakeshadr opened a new pull request #1884:
URL: https://github.com/apache/ozone/pull/1884
## What changes were proposed in this pull request?
This is a follow-up Jira to update TestRootedOzoneFileSystem test class and run against all the configured parameters combinations.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4784
## How was this patch tested?
Through existing TestRootedOzoneFileSystem case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] github-actions[bot] commented on pull request #1884: HDDS-4784. TestRootedOzoneFileSystem is not picking the configured 'Parameters'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1884:
URL: https://github.com/apache/ozone/pull/1884#issuecomment-804498426
Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author.
It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.
If you need ANY help to finish this PR, please [contact the community](https://github.com/apache/hadoop-ozone#contact) on the mailing list or the slack channel."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on pull request #1884: HDDS-4784. TestRootedOzoneFileSystem is not picking the configured 'Parameters'
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #1884:
URL: https://github.com/apache/ozone/pull/1884#issuecomment-776235766
Thanx @rakeshadr for taking this up.
I think only two `testDeleteCreatesFakeParentDir` and `testMkdirOnNonExistentVolumeBucketDir` are broken, the other two are failing because, these two failed test didn't clean up properly.
Doesn't look like a bug, should be a test only issue. Changing to `fs.exists(key)` from getting key and validating fixes all of them(for me). Give a check if that does for you too.
Something like this, Just for reference:
```
diff --git a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
index 98e535496..777760675 100644
--- a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
+++ b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
@@ -247,12 +247,8 @@ public void testDeleteCreatesFakeParentDir() throws Exception {
// Delete the child key
Assert.assertTrue(fs.delete(child, false));
- // Deleting the only child should create the parent dir key if it does
- // not exist
- OFSPath parentOFSPath = new OFSPath(parent);
- String parentKey = parentOFSPath.getKeyName() + "/";
- OzoneKeyDetails parentKeyInfo = getKey(parent, true);
- Assert.assertEquals(parentKey, parentKeyInfo.getName());
+ // Deleting the only child should not delete the parent
+ Assert.assertNotNull(fs.exists(parent));
// Recursive delete with DeleteIterator
Assert.assertTrue(fs.delete(grandparent, true));
@@ -339,11 +335,7 @@ public void testMkdirOnNonExistentVolumeBucketDir() throws Exception {
// Check volume and bucket existence, they should both be created.
OzoneVolume ozoneVolume = objectStore.getVolume(volumeNameLocal);
- OzoneBucket ozoneBucket = ozoneVolume.getBucket(bucketNameLocal);
- OFSPath ofsPathDir1 = new OFSPath(dir12);
- String key = ofsPathDir1.getKeyName() + "/";
- OzoneKeyDetails ozoneKeyDetails = ozoneBucket.getKey(key);
- Assert.assertEquals(key, ozoneKeyDetails.getName());
+ Assert.assertTrue(fs.exists(dir12));
// Verify that directories are created.
FileStatus[] fileStatuses = ofs.listStatus(root);
```
HDDS-4102, seems to have introduced this with `enabledFileSystemPaths` it `normalizes` the key path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on pull request #1884: HDDS-4784. TestRootedOzoneFileSystem is not picking the configured 'Parameters'
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #1884:
URL: https://github.com/apache/ozone/pull/1884#issuecomment-771676121
**Note:** Following test cases are failing in my local environment. It is expected to fail in QA as well and need to analyse it for the cause.
```
Parameters:
0: new Object[]{true, true}
1: new Object[]{true, false}
```
```
testDeleteCreatesFakeParentDir[0]
testMkdirOnNonExistentVolumeBucketDir[0]
testListStatusOnLargeDirectory[0]
testListStatusInBucket[0]
```
```
testDeleteCreatesFakeParentDir[1]
testMkdirOnNonExistentVolumeBucketDir[1]
testListStatusOnLargeDirectory[1]
testListStatusInBucket[1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] github-actions[bot] closed pull request #1884: HDDS-4784. TestRootedOzoneFileSystem is not picking the configured 'Parameters'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1884:
URL: https://github.com/apache/ozone/pull/1884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on pull request #1884: HDDS-4784. TestRootedOzoneFileSystem is not picking the configured 'Parameters'
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #1884:
URL: https://github.com/apache/ozone/pull/1884#issuecomment-771676121
**Note:** Following test cases are failing in my local environment. It is expected to fail in QA as well and need to analyse it for the cause.
```
Parameters:
0: new Object[]{true, true}
1: new Object[]{true, false}
```
```
testDeleteCreatesFakeParentDir[0]
testMkdirOnNonExistentVolumeBucketDir[0]
testListStatusOnLargeDirectory[0]
testListStatusInBucket[0]
```
```
testDeleteCreatesFakeParentDir[1]
testMkdirOnNonExistentVolumeBucketDir[1]
testListStatusOnLargeDirectory[1]
testListStatusInBucket[1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #1884: HDDS-4784. TestRootedOzoneFileSystem is not picking the configured 'Parameters'
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1884:
URL: https://github.com/apache/ozone/pull/1884#issuecomment-787920314
/pending pending on comments from @ayushtkn and failing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org