You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "leizhiyuan (via GitHub)" <gi...@apache.org> on 2023/05/22 07:17:43 UTC
[GitHub] [rocketmq] leizhiyuan opened a new pull request, #6787: feat: support cos tiered storage
leizhiyuan opened a new pull request, #6787:
URL: https://github.com/apache/rocketmq/pull/6787
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #issue_id
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6787: [ISSUE #6788] support cos tiered storage
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6787:
URL: https://github.com/apache/rocketmq/pull/6787#issuecomment-1556700285
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6787?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#6787](https://app.codecov.io/gh/apache/rocketmq/pull/6787?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8696f0c) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/bd7db7ec62164882ce6db101bacd038308648e02?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bd7db7e) will **decrease** coverage by `0.11%`.
> The diff coverage is `2.87%`.
> :exclamation: Current head 8696f0c differs from pull request most recent head 3df7d88. Consider uploading reports for the commit 3df7d88 to get more accurate results
```diff
@@ Coverage Diff @@
## develop #6787 +/- ##
=============================================
- Coverage 42.92% 42.81% -0.11%
+ Complexity 8985 8983 -2
=============================================
Files 1104 1105 +1
Lines 78376 78515 +139
Branches 10203 10208 +5
=============================================
- Hits 33645 33619 -26
- Misses 40512 40684 +172
+ Partials 4219 4212 -7
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ketmq/tieredstore/provider/cos/CosFileSegment.java](https://app.codecov.io/gh/apache/rocketmq/pull/6787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL3Byb3ZpZGVyL2Nvcy9Db3NGaWxlU2VnbWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...q/tieredstore/common/TieredMessageStoreConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/6787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2NvbW1vbi9UaWVyZWRNZXNzYWdlU3RvcmVDb25maWcuamF2YQ==) | `61.58% <25.00%> (-3.96%)` | :arrow_down: |
... and [20 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6787/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] leizhiyuan closed pull request #6787: [ISSUE #6788] support cos tiered storage
Posted by "leizhiyuan (via GitHub)" <gi...@apache.org>.
leizhiyuan closed pull request #6787: [ISSUE #6788] support cos tiered storage
URL: https://github.com/apache/rocketmq/pull/6787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Jason918 commented on a diff in pull request #6787: [ISSUE #6788] support cos tiered storage
Posted by "Jason918 (via GitHub)" <gi...@apache.org>.
Jason918 commented on code in PR #6787:
URL: https://github.com/apache/rocketmq/pull/6787#discussion_r1200144310
##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/common/TieredMessageStoreConfig.java:
##########
@@ -123,6 +123,12 @@ public boolean check(TieredStorageLevel targetLevel) {
private String ossAccessKey = "";
private String ossSecretKey = "";
+ // only for oss storage provider
Review Comment:
oss -> cos?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] leizhiyuan commented on pull request #6787: [ISSUE #6788] support cos tiered storage
Posted by "leizhiyuan (via GitHub)" <gi...@apache.org>.
leizhiyuan commented on PR #6787:
URL: https://github.com/apache/rocketmq/pull/6787#issuecomment-1558260690
see https://github.com/apache/rocketmq/pull/6794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org