You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Dongjoon Hyun (Jira)" <ji...@apache.org> on 2019/09/15 07:31:00 UTC

[jira] [Resolved] (SPARK-29081) Replace calls to SerializationUtils.clone on properties with a faster implementation.

     [ https://issues.apache.org/jira/browse/SPARK-29081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun resolved SPARK-29081.
-----------------------------------
    Fix Version/s: 3.0.0
       Resolution: Fixed

This is resolved via https://github.com/apache/spark/pull/25787

> Replace calls to SerializationUtils.clone on properties with a faster implementation.
> -------------------------------------------------------------------------------------
>
>                 Key: SPARK-29081
>                 URL: https://issues.apache.org/jira/browse/SPARK-29081
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 2.4.4
>            Reporter: David Lewis
>            Priority: Minor
>             Fix For: 3.0.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> I don't have empirical evidence, but due to the sheer number of times I have seen spark in the SerializationUtils.clone method in stack traces I've taken I figured it could use some love.
> This functionality was implemented to fix a bug where we were accidentally modifying the properties man used by other threads. That solution was to use SerializationUtils.clone, but that is not necessary. I suggest just creating a new Properties object and iterating over the key-value pairs in the original map and adding them one by one.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org