You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Mathias Herberts (JIRA)" <ji...@apache.org> on 2009/11/13 23:24:39 UTC

[jira] Commented: (THRIFT-551) Enumeration doesn't generate real enum in Java

    [ https://issues.apache.org/jira/browse/THRIFT-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777696#action_12777696 ] 

Mathias Herberts commented on THRIFT-551:
-----------------------------------------

Won't the ENUM=16 in class TType break TCompactProtocol which encodes field id deltas (if field id is less than 16 apart from previous field id) as upper 4 bits (with lower 4 bits being field type)?

> Enumeration doesn't generate real enum in Java
> ----------------------------------------------
>
>                 Key: THRIFT-551
>                 URL: https://issues.apache.org/jira/browse/THRIFT-551
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Java)
>            Reporter: Sammy Yu
>            Assignee: Bryan Duxbury
>         Attachments: thrift-551.patch
>
>
> When a enum is specified in the interface file, the code that is generated for Java just creates a empty class with a list of static integer constants, a list of valid values, and a map of values to names.  It would be better if the enum is created instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.