You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by "snoopdave (via GitHub)" <gi...@apache.org> on 2026/10/04 14:03:18 UTC
[PR] Fix blogroll, category and ping target dialogs after an AJAX save [roller]
snoopdave opened a new pull request, #207:
URL: https://github.com/apache/roller/pull/207
## Summary
Each Roller page carries one form salt, shared by all of its forms, and a salt can be used only once. The blogroll, category and ping target pages save a dialog with AJAX and then post the page form again. The second post sent the salt the AJAX request had already used, so it was refused and the user got an error page. A retry after a "name already in use" message failed the same way.
- **New `refreshSalt(html)` in `theme/scripts/roller.js`.** It reads the salt issued with an AJAX response (parsed with `DOMParser`, so no scripts run) and copies it into every `salt` field on the page.
- **Called first in each AJAX `done` handler:**
- `Bookmarks.jsp`: rename blogroll, add or edit blogroll, save bookmark
- `Categories.jsp`: save category
- `PingTargets.jsp`: save ping target
- **"Switch to blogroll" no longer submits on `mouseup`.** Chrome fires `mouseup` when the list opens, so the page reloaded before a blogroll could be picked. `onchange` is kept.
No Java changes.
## Testing
- Found during manual 6.1.7 testing: adding a blogroll returned 500 from `POST bookmarks!view.rol` ("Security Violation" from `SaltValidator`), and the blogroll selector reloaded on every click.
- Manual retest on the 6.1.7 integration build: pending.
Targets `roller-6.1.x` for 6.1.7. It will be cherry-picked to `master` after the 6.1.7 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix blogroll, category and ping target dialogs, and AtomPub media collections [roller]
Posted by "snoopdave (via GitHub)" <gi...@apache.org>.
snoopdave commented on PR #207:
URL: https://github.com/apache/roller/pull/207#issuecomment-5981388452
Manually tested on the 6.1.7 integration build (Tomcat 9, JDK 11, MySQL 8). Pass.
- **Blogroll:**
- Adding a blogroll no longer returns 500.
- A duplicate name shows the error, and a retry saves.
- Rename works, and so does adding a bookmark after a rename.
- "Switch to blogroll" lets you pick a blogroll.
- **Categories and ping targets:** a duplicate name or invalid URL shows the error, and a retry saves.
- No "Security Violation" errors appear after the fix.
- **AtomPub media:**
- Listing `/resources/default` returns 200, and unknown directories return 404.
- Uploads with no `Slug` and no title, uploads to `/resources`, and uploads with `Slug: ab` all return 201.
- `mvn -pl app test` on JDK 11: 388 tests, 0 failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bugs found while testing the 6.1.7 integration build [roller]
Posted by "snoopdave (via GitHub)" <gi...@apache.org>.
snoopdave merged PR #207:
URL: https://github.com/apache/roller/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix blogroll, category and ping target dialogs, AtomPub media, the Planet feed title, and double image paste [roller]
Posted by "snoopdave (via GitHub)" <gi...@apache.org>.
snoopdave commented on PR #207:
URL: https://github.com/apache/roller/pull/207#issuecomment-5982668987
Follow-up testing on the 6.1.7 integration build. Pass.
- 7238d9617: an image copied from a web page and pasted into the rich text editor now goes in once, not twice. Checked with a real paste.
- dec26dd86: the configuration page accepts decimal values, such as 0.30 MB for the upload limit. The browser had refused anything but whole numbers.
- Regression smoke test: login and logout, entry delete, a logged-out comment, the feeds, search, media folder create, move and delete, and 17 admin and author pages all work. No errors were logged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org