You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/08 11:02:48 UTC

[GitHub] [airflow] ashb commented on a change in pull request #6954: [AIRFLOW-4355] removed task should not lead to dagrun success

ashb commented on a change in pull request #6954: [AIRFLOW-4355] removed task should not lead to dagrun success
URL: https://github.com/apache/airflow/pull/6954#discussion_r364176253
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -565,6 +565,9 @@ dag_dir_list_interval = 300
 # How often should stats be printed to the logs
 print_stats_interval = 30
 
+# A DagRun can have a 'removed' task instance and still lead to DagRun 'success' state when False
 
 Review comment:
   Reading this I don't know what this does.
   
   Can you explain (to me here) what this does, so we can come up with a better doc comment here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services