You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2017/12/24 02:51:00 UTC
[jira] [Commented] (KAFKA-5802) ScramServerCallbackHandler#handle
should check username not being null before calling credentialCache.get()
[ https://issues.apache.org/jira/browse/KAFKA-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302643#comment-16302643 ]
Ted Yu commented on KAFKA-5802:
-------------------------------
lgtm
> ScramServerCallbackHandler#handle should check username not being null before calling credentialCache.get()
> -----------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-5802
> URL: https://issues.apache.org/jira/browse/KAFKA-5802
> Project: Kafka
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> {code}
> String username = null;
> for (Callback callback : callbacks) {
> if (callback instanceof NameCallback)
> username = ((NameCallback) callback).getDefaultName();
> else if (callback instanceof ScramCredentialCallback)
> ((ScramCredentialCallback) callback).scramCredential(credentialCache.get(username));
> {code}
> Since ConcurrentHashMap, used by CredentialCache, doesn't allow null keys, we should check that username is not null before calling credentialCache.get()
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)