You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/02 00:50:13 UTC

[GitHub] [spark] leanken commented on a change in pull request #29304: [SPARK-32494][SQL] Null Aware Anti Join Optimize Support Multi-Column

leanken commented on a change in pull request #29304:
URL: https://github.com/apache/spark/pull/29304#discussion_r464015628



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
##########
@@ -393,33 +395,42 @@ object PhysicalWindow {
 
 object ExtractSingleColumnNullAwareAntiJoin extends JoinSelectionHelper with PredicateHelper {

Review comment:
       how about ExtractNullAwareAntiJoinKeys




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org