You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhilinli123 (via GitHub)" <gi...@apache.org> on 2023/05/25 02:19:17 UTC
[GitHub] [seatunnel] zhilinli123 opened a new pull request, #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
zhilinli123 opened a new pull request, #4826:
URL: https://github.com/apache/seatunnel/pull/4826
…ed after conversion
hive to hive is failed #4809
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#issuecomment-1578894255
@Hisoka-X @TyrantLucifer Re-run CI and review. Thank you, boss
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#issuecomment-1657808375
PTAL: @TyrantLucifer @TaoZex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] TaoZex commented on a diff in pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "TaoZex (via GitHub)" <gi...@apache.org>.
TaoZex commented on code in PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#discussion_r1214522120
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/SourceExecuteProcessor.java:
##########
@@ -71,13 +71,17 @@ public List<DataStream<Row>> execute(List<DataStream<Row>> upstreamDataStreams)
} else {
sourceFunction = new SeaTunnelParallelSource(internalSource);
}
+ boolean bounded =
+ internalSource.getBoundedness()
+ == org.apache.seatunnel.api.source.Boundedness.BOUNDED
+ ? true
+ : false;
Review Comment:
```suggestion
boolean bounded = internalSource.getBoundedness() == org.apache.seatunnel.api.source.Boundedness.BOUNDED
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#issuecomment-1562170054
```
hive Source:
create table test3 (
name string,
age int,
emails ARRAY<STRING>,
phones map<STRING, string>
);
INSERT INTO TABLE test3
VALUES ('list',12,array("zhangsan@qq.com", "lisi@sohu.com", "wangwu@sina.com"), map('home', "13987167117", 'office', "15178968888"));
hive Sink:
create table test3_sink (
name string,
age int,
emails ARRAY<STRING>,
phones map<STRING, string>
);
Conf :
env {
# You can set spark configuration here
execution.parallelism = 1
job.mode = "BATCH"
}
source {
Hive {
table_name = "default.test3"
metastore_uri = "thrift://localhost:9083"
result_table_name = "user"
}
}
transform {
# If you would like to get more information about how to configure seatunnel and see full list of transform plugins,
# please go to https://seatunnel.apache.org/docs/category/transform
Replace {
source_table_name = "user"
result_table_name = "user_1"
replace_field = "name"
pattern = "s"
replacement = "w"
is_regex = true
replace_first=true
}
}
sink {
# Console{ source_table_name = "user" }
Hive {
source_table_name = "user_1"
table_name = "default.test3_sink"
metastore_uri = "thrift://localhost:9083"
}
}
table result test3_sink :
liwt 12 ["zhangsan@qq.com","lisi@sohu.com","wangwu@sina.com"] {"office":"15178968888","home":"13987167117"}
```
<img width="1313" alt="image" src="https://github.com/apache/seatunnel/assets/76689593/5260d904-7c7f-4066-b9a0-660fec3646ea">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y commented on pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#issuecomment-1666488764
Waiting for the e2e issue to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#issuecomment-1576335731
<img width="1440" alt="image" src="https://github.com/apache/seatunnel/assets/76689593/7385f8b7-c2ae-4c03-9b41-9fb53db0fa9d">
Ci rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] TyrantLucifer commented on a diff in pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on code in PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#discussion_r1206763045
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/split/FileSourceSplitEnumerator.java:
##########
@@ -123,8 +123,10 @@ public int currentUnassignedSplitSize() {
@Override
public void registerReader(int subtaskId) {
+ Set<Integer> readers = context.registeredReaders();
Review Comment:
Why change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#issuecomment-1562165879
PTAL:@TyrantLucifer @hailin0 @ashulin thks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 closed pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 closed pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
URL: https://github.com/apache/seatunnel/pull/4826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y merged pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y merged PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on a diff in pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on code in PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#discussion_r1217329238
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/SourceExecuteProcessor.java:
##########
@@ -71,13 +71,17 @@ public List<DataStream<Row>> execute(List<DataStream<Row>> upstreamDataStreams)
} else {
sourceFunction = new SeaTunnelParallelSource(internalSource);
}
+ boolean bounded =
+ internalSource.getBoundedness()
+ == org.apache.seatunnel.api.source.Boundedness.BOUNDED
+ ? true
+ : false;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on a diff in pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on code in PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#discussion_r1207702042
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/split/FileSourceSplitEnumerator.java:
##########
@@ -123,8 +123,10 @@ public int currentUnassignedSplitSize() {
@Override
public void registerReader(int subtaskId) {
+ Set<Integer> readers = context.registeredReaders();
Review Comment:
> Why change it?
I just reconfirmed that there is no such problem, I have restored it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#issuecomment-1666879624
> Waiting for the e2e issue to be fixed.
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#issuecomment-1669455117
ci run @ic4y @liugddx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#issuecomment-1562217290
<img width="1440" alt="image" src="https://github.com/apache/seatunnel/assets/76689593/7cc756b0-4f45-4ec7-83e8-5cb3d061a4e2">
Rerun CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhilinli123 commented on pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "zhilinli123 (via GitHub)" <gi...@apache.org>.
zhilinli123 commented on PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#issuecomment-1571573901
PTAL: @TyrantLucifer @hailin0 Thank you for your help in reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y commented on pull request #4826: [Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set to`job.mode`
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4826:
URL: https://github.com/apache/seatunnel/pull/4826#issuecomment-1672994175
@TyrantLucifer PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org