[myfaces] branch main updated: MYFACES-4500: throw ISE in ajax request if redirect is already completed (#380)

[me...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

melloware pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/myfaces.git


The following commit(s) were added to refs/heads/main by this push:
     new 0d2bd615f MYFACES-4500: throw ISE in ajax request if redirect is already completed (#380)
0d2bd615f is described below

commit 0d2bd615fb24d3b33101834e32a0874476994af9
Author: Volodymyr Siedlecki <vo...@gmail.com>
AuthorDate: Mon Nov 14 16:18:45 2022 -0500

    MYFACES-4500: throw ISE in ajax request if redirect is already completed (#380)
---
 .../apache/myfaces/context/servlet/ServletExternalContextImpl.java    | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java b/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java
index a9b7fb29f..216dff9b3 100755
--- a/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java
+++ b/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java
@@ -589,6 +589,10 @@ public final class ServletExternalContextImpl extends ServletExternalContextImpl
         PartialViewContext partialViewContext = facesContext.getPartialViewContext(); 
         if (partialViewContext.isPartialRequest())
         {
+            if (_servletResponse instanceof HttpServletResponse && facesContext.getResponseComplete())
+            {
+                throw new IllegalStateException();
+            }
             PartialResponseWriter writer = partialViewContext.getPartialResponseWriter();
             this.setResponseContentType("text/xml");
             this.setResponseCharacterEncoding("UTF-8");