You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@community.apache.org by "sebbASF (via GitHub)" <gi...@apache.org> on 2023/03/29 18:13:16 UTC

[GitHub] [comdev-site] sebbASF opened a new pull request, #99: += pagefind

sebbASF opened a new pull request, #99:
URL: https://github.com/apache/comdev-site/pull/99

   Sample config


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org


[GitHub] [comdev-site] sebbASF commented on pull request #99: += pagefind

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #99:
URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1489956097

   I don't know; I guess we will find out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org


[GitHub] [comdev-site] sebbASF commented on pull request #99: += pagefind

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #99:
URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490182314

   Seems to be building OK now - OK to merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org


[GitHub] [comdev-site] bdelacretaz commented on pull request #99: += pagefind

Posted by "bdelacretaz (via GitHub)" <gi...@apache.org>.
bdelacretaz commented on PR #99:
URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490115972

   ...and BTW it would be good to verify checksums when downloading external tools.
   
   I've never done this in a Jenkinsfile myself but https://www.jenkins.io/doc/pipeline/steps/pipeline-utility-steps/#verifysha256-verify-the-sha256-of-a-given-file has a suggestion , assuming that https://plugins.jenkins.io/pipeline-utility-steps/ are installed on our Jenkins services.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org


[GitHub] [comdev-site] rlenferink commented on pull request #99: += pagefind

Posted by "rlenferink (via GitHub)" <gi...@apache.org>.
rlenferink commented on PR #99:
URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490626581

   > I've raised INFRA-24405
   
   To be honest: I don't like the idea of globally installed tooling.
   
   Different projects are using different versions of Hugo (Celix uses 0.63.2, Jena uses 0.66.0, MINA 0.63.2, Directory uses Hugo, SIS, Nutch etc). What happens if we rely on version 0.111.3 and in quite some time another project asks INFRA to update to 1.0.0 (or another version which contains a breaking change).
   
   IMO users (different projects) should install what they need themselves (either in a container or in a temporary path as we previously did in the Jenkinsfile). Our website isn't gonna fix itself if INFRA decides to update Hugo within period X. It is better to be in full control then instead of e.g. a build starting to fail (or worse: some side effect we don't directly see, e.g. a successful build but the build generating broken URLs).
   
   (speaking from personal experience at `$work` that not pinning tooling versions is a path you don't want to take)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org


[GitHub] [comdev-site] sebbASF commented on pull request #99: += pagefind

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #99:
URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1491069518

   Well, Python and Ruby etc are all shared installs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org


[GitHub] [comdev-site] bdelacretaz commented on pull request #99: += pagefind

Posted by "bdelacretaz (via GitHub)" <gi...@apache.org>.
bdelacretaz commented on PR #99:
URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1489924461

   Is `npx` available on the Jenkins build?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org


[GitHub] [comdev-site] bdelacretaz commented on pull request #99: += pagefind

Posted by "bdelacretaz (via GitHub)" <gi...@apache.org>.
bdelacretaz commented on PR #99:
URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490093022

   You might also install a `pagefind` binary ( https://github.com/CloudCannon/pagefind/releases ) from the `Jenkinsfile`, similar to how Hugo is installed for this build? Pagefind installation instructions are at https://pagefind.app/docs/installation/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org


[GitHub] [comdev-site] sebbASF commented on pull request #99: += pagefind

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #99:
URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490080175

   I've raised INFRA-24405


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org


[GitHub] [comdev-site] sebbASF merged pull request #99: += pagefind

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF merged PR #99:
URL: https://github.com/apache/comdev-site/pull/99


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org


[GitHub] [comdev-site] rlenferink commented on pull request #99: += pagefind

Posted by "rlenferink (via GitHub)" <gi...@apache.org>.
rlenferink commented on PR #99:
URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490049905

   This looks quite neat when tested locally! I updated the README with the steps I had to execute to get this working locally.
   
   I checked [the Jenkins build](https://ci-builds.apache.org/job/Community%20Development/job/site/job/pagefind/2/console) for this branch and it seems that `npx` is not available:
   
   ```
   + npx -y pagefind --source /tmp/tmp.Gyx0fKCW5W/content
   /home/jenkins/workspace/munity_Development_site_pagefind@tmp/durable-59bbcbc2/script.sh: 1: npx: not found
   ```
   
   A solution I was thinking of: we could add a `Containerfile` (intentionally not called Dockerfile), add the required tooling there (`hugo`, `npx` etc.) and use that image for building the website in Jenkins, but also for users who want to do local testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org


[GitHub] [comdev-site] sebbASF commented on pull request #99: += pagefind

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #99:
URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490069944

   Rather than a container, maybe it is possible to install hugo and npm/npx in Jenkins?
   That would be useful for others.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org