You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xerces.apache.org by mr...@apache.org on 2009/12/14 07:33:43 UTC
svn commit: r890195 -
/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/dom/ProcessingInstructionImpl.java
Author: mrglavas
Date: Mon Dec 14 06:33:43 2009
New Revision: 890195
URL: http://svn.apache.org/viewvc?rev=890195&view=rev
Log:
JIRA Issue #1380: http://issues.apache.org/jira/browse/XERCESJ-1380. Eliminate redundant implementations of getData() and setData() from ProcessingInstructionImpl which are identical to the implementation of those methods in the parent class (CharacterDataImpl). Patch for removing getData() thanks to Ludger Bünger. I added the removal of setData().
Modified:
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/dom/ProcessingInstructionImpl.java
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/dom/ProcessingInstructionImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/dom/ProcessingInstructionImpl.java?rev=890195&r1=890194&r2=890195&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/dom/ProcessingInstructionImpl.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/dom/ProcessingInstructionImpl.java Mon Dec 14 06:33:43 2009
@@ -17,7 +17,6 @@
package org.apache.xerces.dom;
-import org.w3c.dom.DOMException;
import org.w3c.dom.Node;
import org.w3c.dom.ProcessingInstruction;
@@ -106,40 +105,6 @@
} // getTarget():String
- /**
- * A PI's data content tells the processor what we actually want it
- * to do. It is defined slightly differently in HTML and XML.
- * <p>
- * In XML, the data begins with the non-whitespace character
- * immediately after the target -- @see getTarget().
- * <p>
- * In HTML, the data begins with the character immediately after the
- * "<?" token that begins the PI.
- * <p>
- * Note that getNodeValue is aliased to getData
- */
- public String getData() {
- if (needsSyncData()) {
- synchronizeData();
- }
- return data;
-
- } // getData():String
-
- /**
- * Change the data content of this PI.
- * Note that setData is aliased to setNodeValue.
- * @see #getData().
- * @throws DOMException(NO_MODIFICATION_ALLOWED_ERR) if node is read-only.
- */
- public void setData(String data) {
- // Hand off to setNodeValue for code-reuse reasons (mutation
- // events, readonly protection, synchronizing, etc.)
- setNodeValue(data);
- } // setData(String)
-
-
-
/**
* Returns the absolute base URI of this node or null if the implementation
* wasn't able to obtain an absolute URI. Note: If the URI is malformed, a
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org