You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ha...@apache.org on 2017/07/15 21:35:30 UTC

[01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

Repository: flex-asjs
Updated Branches:
  refs/heads/refactor-strand [created] 41e30e2cf


Core changes to IStrand


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/80580936
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/80580936
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/80580936

Branch: refs/heads/refactor-strand
Commit: 80580936bf28455f7c3573ca96ee14dff396936c
Parents: dd4672b
Author: Harbs <ha...@in-tools.com>
Authored: Sat Jul 15 23:57:20 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Sat Jul 15 23:57:20 2017 +0300

----------------------------------------------------------------------
 .../flex/org/apache/flex/core/ElementWrapper.as | 61 ++++++++++++++++++++
 .../main/flex/org/apache/flex/core/IStrand.as   | 24 ++++++++
 .../main/flex/org/apache/flex/core/Strand.as    | 29 ++++++++++
 .../apache/flex/utils/MXMLDataInterpreter.as    |  4 +-
 4 files changed, 116 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/80580936/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
index b744edb..53785ac 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
@@ -60,11 +60,29 @@ package org.apache.flex.core
             _element = value;
         }
         
+        private var beads:Array;
+
         protected var _beads:Vector.<IBead>;
         
         //--------------------------------------
         //   Function
         //--------------------------------------
+
+        /**
+         *  @copy org.apache.flex.core.IStrand#registerBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function registerBead(bead:IBead):void
+        {
+            if(beads)
+                beads.push(bead);
+            else
+                beads = [bead];
+        }
         
         /**
          * @param bead The new bead.
@@ -79,6 +97,19 @@ package org.apache.flex.core
             _beads.push(bead);
             bead.strand = this;
         }
+
+        /**
+         *  @copy org.apache.flex.core.IStrand#addBeads()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function addBeads():void
+        {
+            addBeadsToStrand(this,beads);
+        }
         
         /**
          * @param classOrInterface The requested bead type.
@@ -228,6 +259,7 @@ package org.apache.flex.core
             _element = value;
         }
         
+        private var beads:Array;
 
 		protected var _beads:Vector.<IBead>;
         
@@ -236,6 +268,22 @@ package org.apache.flex.core
 		//--------------------------------------
 
         /**
+         *  @copy org.apache.flex.core.IStrand#registerBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function registerBead(bead:IBead):void
+        {
+            if(beads)
+                beads.push(bead);
+            else
+                beads = [bead];
+        }
+
+        /**
          * @param bead The new bead.
          */
 		public function addBead(bead:IBead):void
@@ -250,6 +298,19 @@ package org.apache.flex.core
 		}
 
         /**
+         *  @copy org.apache.flex.core.IStrand#addBeads()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function addBeads():void
+        {
+            addBeadsToStrand(this,beads);
+        }
+
+        /**
          * @param classOrInterface The requested bead type.
          * @return The bead.
          */

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/80580936/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IStrand.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IStrand.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IStrand.as
index b6e8b20..a60e340 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IStrand.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IStrand.as
@@ -37,6 +37,18 @@ package org.apache.flex.core
 	public interface IStrand
 	{
         /**
+         *  Registers a bead to be add to the strand.
+         *
+         *  @param bead The bead to be added.
+         * 
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+		function registerBead(bead:IBead):void;
+
+        /**
          *  Add a bead to the strand.
          *
          *  @param bead The bead to be added.
@@ -47,6 +59,18 @@ package org.apache.flex.core
          *  @productversion FlexJS 0.0
          */
 		function addBead(bead:IBead):void;
+
+        /**
+         *  Add the beads registered to the strand.
+         *
+         *  @param bead The bead to be added.
+         * 
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+		function addBeads():void;
         
         /**
          *  Find a bead on the strand.

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/80580936/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Strand.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Strand.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Strand.as
index b0318d6..f4953fa 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Strand.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Strand.as
@@ -120,6 +120,22 @@ package org.apache.flex.core
 		private var _beads:Vector.<IBead>;
 
         /**
+         *  @copy org.apache.flex.core.IStrand#registerBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function registerBead(bead:IBead):void
+        {
+            if(beads)
+                beads.push(bead);
+            else
+                beads = [bead];
+        }
+
+        /**
          *  @copy org.apache.flex.core.IStrand#addBead()
          *  
          *  @langversion 3.0
@@ -136,6 +152,19 @@ package org.apache.flex.core
 				_model = bead as IBeadModel;
 			bead.strand = this;
 		}
+
+        /**
+         *  @copy org.apache.flex.core.IStrand#addBeads()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function addBeads():void
+        {
+            addBeadsToStrand(this,beads);
+        }
 		
         /**
          *  @copy org.apache.flex.core.IStrand#getBeadByType()

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/80580936/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/MXMLDataInterpreter.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/MXMLDataInterpreter.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/MXMLDataInterpreter.as
index 6f24181..704503d 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/MXMLDataInterpreter.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/MXMLDataInterpreter.as
@@ -191,8 +191,8 @@ public class MXMLDataInterpreter
             else if (simple == false)
                 value = generateMXMLObject(document, value as Array);
             comp[name] = value;
-            if (value is IBead && comp is IStrand)
-                IStrand(comp).addBead(value as IBead);
+            // if (value is IBead && comp is IStrand)
+            //     IStrand(comp).addBead(value as IBead);
         }
         var beadOffset:int = i + (m - 1) * 3;
         //if (beadOffset >= -1)


[04/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - IStrand changes to Basic

Posted by ha...@apache.org.
IStrand changes to Basic


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/c20bc2db
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/c20bc2db
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/c20bc2db

Branch: refs/heads/refactor-strand
Commit: c20bc2db5e8080f7cd6952a0990eb036dab2aa91
Parents: da96465
Author: Harbs <ha...@in-tools.com>
Authored: Sat Jul 15 23:58:44 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Sat Jul 15 23:58:44 2017 +0300

----------------------------------------------------------------------
 .../flex/org/apache/flex/core/Application.as    | 36 ++++++++++-
 .../org/apache/flex/core/HTMLElementWrapper.as  | 67 ++++++++++++++++++++
 .../main/flex/org/apache/flex/core/UIBase.as    | 15 +++--
 .../flex/org/apache/flex/core/UIButtonBase.as   | 30 +++++++++
 .../flex/org/apache/flex/html/MXMLBeadView.as   | 36 +++++++++--
 .../org/apache/flex/html/beads/TextAreaView.as  | 33 +++++++++-
 .../supportClasses/TextFieldItemRenderer.as     | 30 +++++++++
 7 files changed, 233 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c20bc2db/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/Application.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/Application.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/Application.as
index c92ad95..2bda2ad 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/Application.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/Application.as
@@ -33,6 +33,7 @@ package org.apache.flex.core
         import flash.events.Event;
         import flash.system.ApplicationDomain;
         import flash.utils.getQualifiedClassName;
+        import org.apache.flex.core.addBeadsToStrand
         import org.apache.flex.events.utils.MouseEventConverter;
     }
 
@@ -347,20 +348,37 @@ package org.apache.flex.core
 
         /**
          *  The array property that is used to add additional
-         *  beads to an MXML tag.  From ActionScript, just
-         *  call addBead directly.
+         *  beads to an MXML tag.  From ActionScript, use registerBead().
          *
          *  @langversion 3.0
          *  @playerversion Flash 10.2
          *  @playerversion AIR 2.6
          *  @productversion FlexJS 0.0
          */
+        COMPILE::SWF
         public var beads:Array;
 
         COMPILE::SWF
         private var _beads:Vector.<IBead>;
 
         /**
+         *  @copy org.apache.flex.core.IStrand#registerBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        COMPILE::SWF
+        public function registerBead(bead:IBead):void
+        {
+            if(beads)
+                beads.push(bead);
+            else
+                beads = [bead];
+        }
+
+        /**
          *  @copy org.apache.flex.core.IStrand#addBead()
          *
          *  @langversion 3.0
@@ -378,6 +396,20 @@ package org.apache.flex.core
         }
 
         /**
+         *  @copy org.apache.flex.core.IStrand#addBeads()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        COMPILE::SWF
+        public function addBeads():void
+        {
+            addBeadsToStrand(this,beads);
+        }
+
+        /**
          *  @copy org.apache.flex.core.IStrand#getBeadByType()
          *
          *  @langversion 3.0

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c20bc2db/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as
index f104b83..c65bba6 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/HTMLElementWrapper.as
@@ -18,6 +18,8 @@
 ////////////////////////////////////////////////////////////////////////////////
 package org.apache.flex.core
 {
+    import org.apache.flex.core.addBeadsToStrand;
+    
     COMPILE::SWF
     {
         import flash.display.Sprite;
@@ -38,12 +40,34 @@ package org.apache.flex.core
     public class HTMLElementWrapper extends Sprite
     {
         /**
+         *  @copy org.apache.flex.core.Application#beads
+         *  
+         *  The beads are not automatically added to the
+         *  strand.  Subclasses must decide when to
+         *  add the beads.
+         * 
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.0
+         */
+		public var beads:Array;
+        
+        /**
          * "abstract" method so we can override in JS
          * @param bead The new bead.
          */
         public function addBead(bead:IBead):void
         {            
         }
+        
+        public function registerBead(bead:IBead):void
+        {
+            if(beads)
+                beads.push(bead);
+            else
+                beads = [bead];
+        }
     }
     
 	COMPILE::JS
@@ -140,6 +164,20 @@ package org.apache.flex.core
             }
         }
 
+        /**
+         *  @copy org.apache.flex.core.Application#beads
+         *  
+         *  The beads are not automatically added to the
+         *  strand.  Subclasses must decide when to
+         *  add the beads.
+         * 
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.0
+         */
+		public var beads:Array;
+        
 		protected var _beads:Vector.<IBead>;
         
 		//--------------------------------------
@@ -147,6 +185,22 @@ package org.apache.flex.core
 		//--------------------------------------
 
         /**
+         *  @copy org.apache.flex.core.IStrand#registerBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function registerBead(bead:IBead):void
+        {
+            if(beads)
+                beads.push(bead);
+            else
+                beads = [bead];
+        }
+
+        /**
          * @param bead The new bead.
          */
 		public function addBead(bead:IBead):void
@@ -167,6 +221,19 @@ package org.apache.flex.core
 		}
 
         /**
+         *  @copy org.apache.flex.core.IStrand#addBeads()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function addBeads():void
+        {
+            addBeadsToStrand(this,beads);
+        }
+
+        /**
          * @param classOrInterface The requested bead type.
          * @return The bead.
          */

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c20bc2db/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
index b9ba8c4..ec38a07 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
@@ -23,6 +23,7 @@ package org.apache.flex.core
         import flash.display.DisplayObject;
         import flash.display.Sprite;
         import flash.display.Stage;
+        import org.apache.flex.core.addBeadsToStrand;
         import org.apache.flex.events.utils.MouseEventConverter;
     }
 	
@@ -1034,17 +1035,21 @@ package org.apache.flex.core
         {
             return this;
         }
-		
+
         /**
-         *  @copy org.apache.flex.core.Application#beads
+         *  @copy org.apache.flex.core.IStrand#addBeads()
          *  
          *  @langversion 3.0
          *  @playerversion Flash 10.2
          *  @playerversion AIR 2.6
-         *  @productversion FlexJS 0.0
+         *  @productversion FlexJS 0.9
          */
-		public var beads:Array;
-		
+        COMPILE::SWF
+        public function addBeads():void
+        {
+            addBeadsToStrand(this,beads);
+        }
+
         COMPILE::SWF
 		private var _beads:Vector.<IBead>;
         

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c20bc2db/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIButtonBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIButtonBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIButtonBase.as
index 0935c2c..bc84800 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIButtonBase.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIButtonBase.as
@@ -21,6 +21,7 @@ package org.apache.flex.core
 	import flash.display.DisplayObject;
 	import flash.display.SimpleButton;
 	
+    import org.apache.flex.core.addBeadsToStrand;
 	import org.apache.flex.core.IBead;
 	import org.apache.flex.core.IBeadModel;
 	import org.apache.flex.core.IMeasurementBead;
@@ -730,6 +731,22 @@ package org.apache.flex.core
 		private var strand:Vector.<IBead>;
 
         /**
+         *  @copy org.apache.flex.core.IStrand#registerBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function registerBead(bead:IBead):void
+        {
+            if(beads)
+                beads.push(bead);
+            else
+                beads = [bead];
+        }
+
+        /**
          *  @copy org.apache.flex.core.UIBase#addBead()
          *  
          *  @langversion 3.0
@@ -750,6 +767,19 @@ package org.apache.flex.core
 		}
 		
         /**
+         *  @copy org.apache.flex.core.IStrand#addBeads()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function addBeads():void
+        {
+            addBeadsToStrand(this,beads);
+        }
+
+        /**
          *  @copy org.apache.flex.core.UIBase#getBeadByType()
          *  
          *  @langversion 3.0

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c20bc2db/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/MXMLBeadView.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/MXMLBeadView.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/MXMLBeadView.as
index 4bfa105..f436e19 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/MXMLBeadView.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/MXMLBeadView.as
@@ -19,7 +19,7 @@
 package org.apache.flex.html
 {
 	import org.apache.flex.states.State;
-
+    import org.apache.flex.core.addBeadsToStrand;
 	import org.apache.flex.core.IBead;
     import org.apache.flex.core.ILayoutHost;
     import org.apache.flex.core.IParent;
@@ -77,10 +77,7 @@ package org.apache.flex.html
 
             dispatchEvent(new Event("strandChanged"));
 
-            for each (var bead:IBead in beads)
-                addBead(bead);
-
-            dispatchEvent(new org.apache.flex.events.Event("beadsAdded"));
+            addBeads();
 
             MXMLDataInterpreter.generateMXMLInstances(this, IParent(value), MXMLDescriptor);
 
@@ -257,6 +254,22 @@ package org.apache.flex.html
         private var _beads:Array;
 
         /**
+         *  @copy org.apache.flex.core.IStrand#registerBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function registerBead(bead:IBead):void
+        {
+            if(beads)
+                beads.push(bead);
+            else
+                beads = [bead];
+        }
+
+        /**
          *  @copy org.apache.flex.core.IStrand#addBead()
          *
          *  @langversion 3.0
@@ -273,6 +286,19 @@ package org.apache.flex.html
         }
 
         /**
+         *  @copy org.apache.flex.core.IStrand#addBeads()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function addBeads():void
+        {
+            addBeadsToStrand(this,beads);
+        }
+
+        /**
          *  @copy org.apache.flex.core.IStrand#getBeadByType()
          *
          *  @langversion 3.0

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c20bc2db/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/TextAreaView.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/TextAreaView.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/TextAreaView.as
index ef25539..e41e446 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/TextAreaView.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/TextAreaView.as
@@ -23,6 +23,7 @@ package org.apache.flex.html.beads
 	import flash.events.IEventDispatcher;
 	import flash.text.TextFieldType;
 	
+	import org.apache.flex.core.addBeadsToStrand;
 	import org.apache.flex.core.IBead;
     import org.apache.flex.core.IBeadModel;
 	import org.apache.flex.core.IScrollBarModel;
@@ -104,8 +105,7 @@ package org.apache.flex.html.beads
 		{
 			super.strand = value;
 			
-            for each (var bead:IBead in beads)
-                addBead(bead);
+            addBeads();
             
 			// add a border to this
 			_border = new Border();
@@ -204,6 +204,22 @@ package org.apache.flex.html.beads
 		private var _beads:Vector.<IBead>;
 
         /**
+         *  @copy org.apache.flex.core.IStrand#registerBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function registerBead(bead:IBead):void
+        {
+            if(beads)
+                beads.push(bead);
+            else
+                beads = [bead];
+        }
+
+        /**
          *  @copy org.apache.flex.core.UIBase#addBead()
          *  
          *  @langversion 3.0
@@ -218,6 +234,19 @@ package org.apache.flex.html.beads
 			_beads.push(bead);
 			bead.strand = this;
 		}
+
+        /**
+         *  @copy org.apache.flex.core.IStrand#addBeads()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function addBeads():void
+        {
+            addBeadsToStrand(this,beads);
+        }
 		
         /**
          *  @copy org.apache.flex.core.UIBase#getBeadByType()

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c20bc2db/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/TextFieldItemRenderer.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/TextFieldItemRenderer.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/TextFieldItemRenderer.as
index bcada9c..1599e20 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/TextFieldItemRenderer.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/TextFieldItemRenderer.as
@@ -21,6 +21,7 @@ package org.apache.flex.html.supportClasses
     import flash.display.DisplayObject;
     import flash.text.TextFieldType;
     
+	import org.apache.flex.core.addBeadsToStrand;
     import org.apache.flex.core.CSSTextField;
     import org.apache.flex.core.IBead;
     import org.apache.flex.core.IBeadController;
@@ -481,6 +482,22 @@ package org.apache.flex.html.supportClasses
         public var beads:Array;
         
         private var _beads:Vector.<IBead>;
+
+        /**
+         *  @copy org.apache.flex.core.IStrand#registerBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function registerBead(bead:IBead):void
+        {
+            if(beads)
+                beads.push(bead);
+            else
+                beads = [bead];
+        }
 		
 		/**
 		 * @private
@@ -492,6 +509,19 @@ package org.apache.flex.html.supportClasses
             _beads.push(bead);
             bead.strand = this;
         }
+
+        /**
+         *  @copy org.apache.flex.core.IStrand#addBeads()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function addBeads():void
+        {
+            addBeadsToStrand(this,beads);
+        }
         
 		/**
 		 * @private


[02/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Forgot addBeadsToStrand

Posted by ha...@apache.org.
Forgot addBeadsToStrand


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/8a688f42
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/8a688f42
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/8a688f42

Branch: refs/heads/refactor-strand
Commit: 8a688f4241cfc166d2eae909990721933ba4c5d9
Parents: 8058093
Author: Harbs <ha...@in-tools.com>
Authored: Sat Jul 15 23:57:47 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Sat Jul 15 23:57:47 2017 +0300

----------------------------------------------------------------------
 .../org/apache/flex/core/addBeadsToStrand.as    | 44 ++++++++++++++++++++
 1 file changed, 44 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/8a688f42/frameworks/projects/Core/src/main/flex/org/apache/flex/core/addBeadsToStrand.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/addBeadsToStrand.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/addBeadsToStrand.as
new file mode 100644
index 0000000..081268c
--- /dev/null
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/addBeadsToStrand.as
@@ -0,0 +1,44 @@
+////////////////////////////////////////////////////////////////////////////////
+//
+//  Licensed to the Apache Software Foundation (ASF) under one or more
+//  contributor license agreements.  See the NOTICE file distributed with
+//  this work for additional information regarding copyright ownership.
+//  The ASF licenses this file to You under the Apache License, Version 2.0
+//  (the "License"); you may not use this file except in compliance with
+//  the License.  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+package org.apache.flex.core
+{
+    import org.apache.flex.events.IEventDispatcher;
+    import org.apache.flex.core.IStrand;
+    import org.apache.flex.events.Event;
+
+    /**
+     * Helper function for IStrand.addBeads()
+     * @langversion 3.0
+     * @playerversion Flash 10.2
+     * @playerversion AIR 2.6
+     * @productversion FlexJS 0.9
+     * @flexjsignorecoercion org.apache.flex.events.IEventDispatcher
+     */
+    public function addBeadsToStrand(strand:IStrand,beads:Array,dispatch:Boolean=true):void
+    {
+        if(beads)
+        {
+            while(beads.length){
+                strand.addBead(beads.shift());
+            }
+        }
+        if(dispatch)
+            (strand as IEventDispatcher).dispatchEvent(new Event("beadsAdded"));
+    }   
+}
\ No newline at end of file


[10/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - IStrand in Network

Posted by ha...@apache.org.
IStrand in Network


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/41e30e2c
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/41e30e2c
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/41e30e2c

Branch: refs/heads/refactor-strand
Commit: 41e30e2cf9c49651046364ccf996ee0bb7d1ec0b
Parents: c003dca
Author: Harbs <ha...@in-tools.com>
Authored: Sun Jul 16 00:33:11 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Sun Jul 16 00:33:11 2017 +0300

----------------------------------------------------------------------
 .../flex/org/apache/flex/core/ElementWrapper.as |   2 +-
 .../flex/org/apache/flex/net/BinaryUploader.as  |  93 -------------
 .../flex/org/apache/flex/net/HTTPService.as     | 103 +-------------
 .../flex/org/apache/flex/net/HTTPServiceBase.as | 135 ++++++++++++++++++-
 4 files changed, 137 insertions(+), 196 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/41e30e2c/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
index 53785ac..c378de5 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
@@ -259,7 +259,7 @@ package org.apache.flex.core
             _element = value;
         }
         
-        private var beads:Array;
+        public var beads:Array;
 
 		protected var _beads:Vector.<IBead>;
         

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/41e30e2c/frameworks/projects/Network/src/main/flex/org/apache/flex/net/BinaryUploader.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/BinaryUploader.as b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/BinaryUploader.as
index b5f660c..f015e2d 100644
--- a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/BinaryUploader.as
+++ b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/BinaryUploader.as
@@ -394,99 +394,6 @@ package org.apache.flex.net
 				dispatchEvent(new Event("idChanged"));
 			}
 		}
-		
-        private var _strand:IStrand;
-        
-        /**
-         *  @copy org.apache.flex.core.UIBase#strand
-         *  
-         *  @langversion 3.0
-         *  @playerversion Flash 10.2
-         *  @playerversion AIR 2.6
-         *  @productversion FlexJS 0.0
-         */        
-        public function set strand(value:IStrand):void
-        {
-            _strand = value;
-            
-            for each (var bead:IBead in beads)
-                addBead(bead);
-            
-            dispatchEvent(new org.apache.flex.events.Event("beadsAdded"));
-        }
-
-        /**
-         *  @copy org.apache.flex.core.UIBase#beads
-         *  
-         *  @langversion 3.0
-         *  @playerversion Flash 10.2
-         *  @playerversion AIR 2.6
-         *  @productversion FlexJS 0.0
-         */        
-		public var beads:Array;
-		
-        COMPILE::SWF
-		private var _beads:Vector.<IBead>;
-
-        /**
-         *  @copy org.apache.flex.core.UIBase#addBead()
-         *  
-         *  @langversion 3.0
-         *  @playerversion Flash 10.2
-         *  @playerversion AIR 2.6
-         *  @productversion FlexJS 0.0
-         */       
-        COMPILE::SWF
-		public function addBead(bead:IBead):void
-		{
-			if (!_beads)
-				_beads = new Vector.<IBead>;
-			_beads.push(bead);
-			bead.strand = this;
-		}
-		
-        /**
-         *  @copy org.apache.flex.core.UIBase#getBeadByType()
-         *  
-         *  @langversion 3.0
-         *  @playerversion Flash 10.2
-         *  @playerversion AIR 2.6
-         *  @productversion FlexJS 0.0
-         */     
-        COMPILE::SWF
-		public function getBeadByType(classOrInterface:Class):IBead
-		{
-			for each (var bead:IBead in _beads)
-			{
-				if (bead is classOrInterface)
-					return bead;
-			}
-			return null;
-		}
-		
-        /**
-         *  @copy org.apache.flex.core.UIBase#removeBead()
-         *  
-         *  @langversion 3.0
-         *  @playerversion Flash 10.2
-         *  @playerversion AIR 2.6
-         *  @productversion FlexJS 0.0
-         */  
-        COMPILE::SWF
-		public function removeBead(value:IBead):IBead	
-		{
-			var n:int = _beads.length;
-			for (var i:int = 0; i < n; i++)
-			{
-				var bead:IBead = _beads[i];
-				if (bead == value)
-				{
-					_beads.splice(i, 1);
-					return bead;
-				}
-			}
-			return null;
-		}
 
         COMPILE::SWF
         private var urlLoader:flash.net.URLLoader;

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/41e30e2c/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
index 23add9c..5c912eb 100644
--- a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
+++ b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
@@ -24,6 +24,7 @@ package org.apache.flex.net
         import flash.events.IOErrorEvent;
         import flash.net.URLLoader;
         import flash.net.URLRequestHeader;
+        import org.apache.flex.core.addBeadsToStrand;
     }
     COMPILE::JS
     {
@@ -409,101 +410,6 @@ package org.apache.flex.net
 				dispatchEvent(new Event("idChanged"));
 			}
 		}
-		
-        private var _strand:IStrand;
-        
-        /**
-         *  @copy org.apache.flex.core.UIBase#strand
-         *  
-         *  @langversion 3.0
-         *  @playerversion Flash 10.2
-         *  @playerversion AIR 2.6
-         *  @productversion FlexJS 0.0
-         */
-        public function set strand(value:IStrand):void
-        {
-            _strand = value;
-            if (_beads == null)
-            {
-                for each (var bead:IBead in beads)
-                    addBead(bead);
-            }
-            
-            dispatchEvent(new org.apache.flex.events.Event("beadsAdded"));
-       }
-
-        /**
-         *  @copy org.apache.flex.core.UIBase#id
-         *  
-         *  @langversion 3.0
-         *  @playerversion Flash 10.2
-         *  @playerversion AIR 2.6
-         *  @productversion FlexJS 0.0
-         */
-		public var beads:Array;
-		
-        COMPILE::SWF
-		private var _beads:Vector.<IBead>;
-        
-        /**
-         *  @copy org.apache.flex.core.UIBase#addBead()
-         *  
-         *  @langversion 3.0
-         *  @playerversion Flash 10.2
-         *  @playerversion AIR 2.6
-         *  @productversion FlexJS 0.0
-         */
-        COMPILE::SWF
-		public function addBead(bead:IBead):void
-		{
-			if (!_beads)
-				_beads = new Vector.<IBead>;
-			_beads.push(bead);
-			bead.strand = this;
-		}
-		
-        /**
-         *  @copy org.apache.flex.core.UIBase#getBeadByType()
-         *  
-         *  @langversion 3.0
-         *  @playerversion Flash 10.2
-         *  @playerversion AIR 2.6
-         *  @productversion FlexJS 0.0
-         */
-        COMPILE::SWF
-		public function getBeadByType(classOrInterface:Class):IBead
-		{
-			for each (var bead:IBead in _beads)
-			{
-				if (bead is classOrInterface)
-					return bead;
-			}
-			return null;
-		}
-		
-        /**
-         *  @copy org.apache.flex.core.UIBase#removeBead()
-         *  
-         *  @langversion 3.0
-         *  @playerversion Flash 10.2
-         *  @playerversion AIR 2.6
-         *  @productversion FlexJS 0.0
-         */
-        COMPILE::SWF
-		public function removeBead(value:IBead):IBead	
-		{
-			var n:int = _beads.length;
-			for (var i:int = 0; i < n; i++)
-			{
-				var bead:IBead = _beads[i];
-				if (bead == value)
-				{
-					_beads.splice(i, 1);
-					return bead;
-				}
-			}
-			return null;
-		}
 
         /**
          *  Allows Javascript cross-site Access-Control requests to be made
@@ -531,11 +437,8 @@ package org.apache.flex.net
          */
         public function send():void
         {
-            if (_beads == null)
-            {
-                for each (var bead:IBead in beads)
-                    addBead(bead);
-            }
+            if(beads && beads.length)
+                addBeads();
 
             dispatchEvent(new Event("preSend"));
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/41e30e2c/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPServiceBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPServiceBase.as b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPServiceBase.as
index 960d76d..5fca120 100644
--- a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPServiceBase.as
+++ b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPServiceBase.as
@@ -18,9 +18,12 @@
 ////////////////////////////////////////////////////////////////////////////////
 package org.apache.flex.net
 {
+	import org.apache.flex.core.IStrand;
     COMPILE::SWF
     {
-        import org.apache.flex.events.EventDispatcher;            
+        import org.apache.flex.events.EventDispatcher;
+        import org.apache.flex.core.addBeadsToStrand;
+        import org.apache.flex.core.IBead;
     }
     COMPILE::JS
     {
@@ -36,12 +39,140 @@ package org.apache.flex.net
      *  @productversion FlexJS 0.0
      */
     COMPILE::SWF
-	public class HTTPServiceBase extends EventDispatcher
+	public class HTTPServiceBase extends EventDispatcher implements IStrand, IBead
 	{
+        private var _strand:IStrand;
+        
+        /**
+         *  @copy org.apache.flex.core.UIBase#strand
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.0
+         */
+        public function set strand(value:IStrand):void
+        {
+            _strand = value;
+            if(beads && beads.length)
+            {
+                addBeads();
+            }
+       }
+
+		public var beads:Array;
+		
+		private var _beads:Vector.<IBead>;
+        
+        /**
+         *  @copy org.apache.flex.core.IStrand#registerBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function registerBead(bead:IBead):void
+        {
+            if(beads)
+                beads.push(bead);
+            else
+                beads = [bead];
+        }
+
+        /**
+         *  @copy org.apache.flex.core.UIBase#addBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.0
+         */
+		public function addBead(bead:IBead):void
+		{
+			if (!_beads)
+				_beads = new Vector.<IBead>;
+			_beads.push(bead);
+			bead.strand = this;
+		}
+
+        /**
+         *  @copy org.apache.flex.core.IStrand#addBeads()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.9
+         */
+        public function addBeads():void
+        {
+            addBeadsToStrand(this,beads);
+        }
+		
+        /**
+         *  @copy org.apache.flex.core.UIBase#getBeadByType()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.0
+         */
+        COMPILE::SWF
+		public function getBeadByType(classOrInterface:Class):IBead
+		{
+			for each (var bead:IBead in _beads)
+			{
+				if (bead is classOrInterface)
+					return bead;
+			}
+			return null;
+		}
+		
+        /**
+         *  @copy org.apache.flex.core.UIBase#removeBead()
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.0
+         */
+        COMPILE::SWF
+		public function removeBead(value:IBead):IBead	
+		{
+			var n:int = _beads.length;
+			for (var i:int = 0; i < n; i++)
+			{
+				var bead:IBead = _beads[i];
+				if (bead == value)
+				{
+					_beads.splice(i, 1);
+					return bead;
+				}
+			}
+			return null;
+		}        
     }
 
     COMPILE::JS
     public class HTTPServiceBase extends ElementWrapper
     {
+        private var _strand:IStrand;
+        
+        /**
+         *  @copy org.apache.flex.core.UIBase#strand
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion FlexJS 0.0
+         */
+        public function set strand(value:IStrand):void
+        {
+            _strand = value;
+            if(beads && beads.length)
+            {
+                addBeads();
+            }
+       }
     }
 }


[07/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Cleaned up overrides

Posted by ha...@apache.org.
Cleaned up overrides


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/bf982c03
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/bf982c03
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/bf982c03

Branch: refs/heads/refactor-strand
Commit: bf982c03eb405e280a427fbb33f1f744b512d14e
Parents: e67f5b3
Author: Harbs <ha...@in-tools.com>
Authored: Sun Jul 16 00:04:41 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Sun Jul 16 00:04:41 2017 +0300

----------------------------------------------------------------------
 .../apache/flex/charts/supportClasses/BoxItemRenderer.as  | 10 ----------
 .../flex/charts/supportClasses/WedgeItemRenderer.as       | 10 ----------
 2 files changed, 20 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/bf982c03/frameworks/projects/Charts/src/main/flex/org/apache/flex/charts/supportClasses/BoxItemRenderer.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Charts/src/main/flex/org/apache/flex/charts/supportClasses/BoxItemRenderer.as b/frameworks/projects/Charts/src/main/flex/org/apache/flex/charts/supportClasses/BoxItemRenderer.as
index 3d30b64..000fad1 100644
--- a/frameworks/projects/Charts/src/main/flex/org/apache/flex/charts/supportClasses/BoxItemRenderer.as
+++ b/frameworks/projects/Charts/src/main/flex/org/apache/flex/charts/supportClasses/BoxItemRenderer.as
@@ -54,16 +54,6 @@ package org.apache.flex.charts.supportClasses
 			super();
 		}
 		
-		override public function addedToParent():void
-		{
-			super.addedToParent();
-		}
-		
-		override public function addBead(bead:IBead):void
-		{
-			super.addBead(bead);
-		}
-		
 		private var _series:IChartSeries;
 		
 		/**

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/bf982c03/frameworks/projects/Charts/src/main/flex/org/apache/flex/charts/supportClasses/WedgeItemRenderer.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Charts/src/main/flex/org/apache/flex/charts/supportClasses/WedgeItemRenderer.as b/frameworks/projects/Charts/src/main/flex/org/apache/flex/charts/supportClasses/WedgeItemRenderer.as
index 6918f35..8d4f356 100644
--- a/frameworks/projects/Charts/src/main/flex/org/apache/flex/charts/supportClasses/WedgeItemRenderer.as
+++ b/frameworks/projects/Charts/src/main/flex/org/apache/flex/charts/supportClasses/WedgeItemRenderer.as
@@ -50,16 +50,6 @@ package org.apache.flex.charts.supportClasses
 			super();
 		}
 		
-		override public function addedToParent():void
-		{
-			super.addedToParent();
-		}
-		
-		override public function addBead(bead:IBead):void
-		{
-			super.addBead(bead);
-		}
-		
 		private var _series:IChartSeries;
 		
 		/**


[06/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Missed this one

Posted by ha...@apache.org.
Missed this one


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/e67f5b30
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/e67f5b30
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/e67f5b30

Branch: refs/heads/refactor-strand
Commit: e67f5b309c04581056107814f229d23b72ca6ee6
Parents: a77e424
Author: Harbs <ha...@in-tools.com>
Authored: Sun Jul 16 00:01:22 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Sun Jul 16 00:01:22 2017 +0300

----------------------------------------------------------------------
 .../flex/org/apache/flex/mdl/supportClasses/MaterialIconBase.as    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/e67f5b30/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/supportClasses/MaterialIconBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/supportClasses/MaterialIconBase.as b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/supportClasses/MaterialIconBase.as
index 88f41f8..caa88ca 100644
--- a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/supportClasses/MaterialIconBase.as
+++ b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/supportClasses/MaterialIconBase.as
@@ -38,7 +38,7 @@ package org.apache.flex.mdl.supportClasses
      *  @playerversion AIR 2.6
      *  @productversion FlexJS 0.8
      */
-    public class MaterialIconBase extends UIBase implements org.apache.flex.mdl.materialIcons.IMaterialIcon
+    public class MaterialIconBase extends UIBase implements IMaterialIcon
     {
         /**
          *  constructor.


[08/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - added stubs to Effects

Posted by ha...@apache.org.
added stubs to Effects


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/6067389e
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/6067389e
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/6067389e

Branch: refs/heads/refactor-strand
Commit: 6067389e1669d5e9a5339906ad87dbb641d12d3d
Parents: bf982c0
Author: Harbs <ha...@in-tools.com>
Authored: Sun Jul 16 00:08:48 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Sun Jul 16 00:08:48 2017 +0300

----------------------------------------------------------------------
 .../src/main/flex/org/apache/flex/utils/MockContentView.as      | 5 +++++
 .../src/main/flex/org/apache/flex/utils/MockLayoutChild.as      | 2 ++
 .../src/main/flex/org/apache/flex/utils/MockLayoutParent.as     | 2 ++
 3 files changed, 9 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/6067389e/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockContentView.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockContentView.as b/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockContentView.as
index ce9b177..0cad68f 100644
--- a/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockContentView.as
+++ b/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockContentView.as
@@ -142,11 +142,16 @@ package org.apache.flex.utils
 			return null;
 		}
 
+		public function registerBead(bead:IBead):void
+		{
+		}
+
 		public function addBead(bead:IBead):void
 		{
 			// TODO Auto Generated method stub
 
 		}
+		public function addBeads():void{}
 
 		public function getBeadByType(classOrInterface:Class):IBead
 		{

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/6067389e/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockLayoutChild.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockLayoutChild.as b/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockLayoutChild.as
index 0dc4f98..21eb275 100644
--- a/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockLayoutChild.as
+++ b/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockLayoutChild.as
@@ -227,6 +227,8 @@ package org.apache.flex.utils
 		public function addBead(bead:IBead):void
 		{
 		}
+		public function registerBead(bead:IBead):void{}
+		public function addBeads():void{}
 		
 		public function getBeadByType(classOrInterface:Class):IBead
 		{

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/6067389e/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockLayoutParent.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockLayoutParent.as b/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockLayoutParent.as
index a07a1d4..b94a8ae 100644
--- a/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockLayoutParent.as
+++ b/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockLayoutParent.as
@@ -165,6 +165,8 @@ package org.apache.flex.utils
 		{
 			// TODO Auto Generated method stub
 		}
+		public function registerBead(bead:IBead):void{}
+		public function addBeads():void{}
 
 		public function getBeadByType(classOrInterface:Class):IBead
 		{


[03/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - CoreClasses

Posted by ha...@apache.org.
CoreClasses


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/da964651
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/da964651
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/da964651

Branch: refs/heads/refactor-strand
Commit: da96465109f93c227154523859b032c75686849e
Parents: 8a688f4
Author: Harbs <ha...@in-tools.com>
Authored: Sat Jul 15 23:58:05 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Sat Jul 15 23:58:05 2017 +0300

----------------------------------------------------------------------
 frameworks/projects/Core/src/main/flex/CoreClasses.as | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/da964651/frameworks/projects/Core/src/main/flex/CoreClasses.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/CoreClasses.as b/frameworks/projects/Core/src/main/flex/CoreClasses.as
index fd89e95..7843543 100644
--- a/frameworks/projects/Core/src/main/flex/CoreClasses.as
+++ b/frameworks/projects/Core/src/main/flex/CoreClasses.as
@@ -26,6 +26,7 @@ package {
  */
 internal class CoreClasses
 {
+	import org.apache.flex.core.addBeadsToStrand; addBeadsToStrand;
     import org.apache.flex.core.BeadViewBase; BeadViewBase;
     import org.apache.flex.core.ImageViewBase; ImageViewBase;
     import org.apache.flex.core.BrowserWindow; BrowserWindow;


[05/10] flex-asjs git commit: cleaned up MDL “implements”

Posted by ha...@apache.org.
cleaned up MDL “implements”


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/a77e4248
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/a77e4248
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/a77e4248

Branch: refs/heads/refactor-strand
Commit: a77e4248ba6fa961b1fad0cb3285b10c68211c80
Parents: c20bc2d
Author: Harbs <ha...@in-tools.com>
Authored: Sat Jul 15 23:59:23 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Sat Jul 15 23:59:23 2017 +0300

----------------------------------------------------------------------
 .../src/main/flex/org/apache/flex/mdl/IconToggle.as                | 2 +-
 .../src/main/flex/org/apache/flex/mdl/RadioButton.as               | 2 +-
 .../MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Switch.as | 2 +-
 .../main/flex/org/apache/flex/mdl/beads/views/SliderThumbView.as   | 2 +-
 .../main/flex/org/apache/flex/mdl/beads/views/SliderTrackView.as   | 2 +-
 .../src/main/flex/org/apache/flex/mdl/beads/views/SliderView.as    | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/a77e4248/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/IconToggle.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/IconToggle.as b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/IconToggle.as
index 36f5d69..381deae 100644
--- a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/IconToggle.as
+++ b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/IconToggle.as
@@ -79,7 +79,7 @@ package org.apache.flex.mdl
      *  @playerversion AIR 2.6
      *  @productversion FlexJS 0.8
      */    
-    public class IconToggle extends TextButton implements IStrand, IEventDispatcher, IUIBase, IMaterialIconProvider
+    public class IconToggle extends TextButton implements IMaterialIconProvider
     {
         /**
          *  constructor.

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/a77e4248/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/RadioButton.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/RadioButton.as b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/RadioButton.as
index f07a048..f807327 100644
--- a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/RadioButton.as
+++ b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/RadioButton.as
@@ -76,7 +76,7 @@ package org.apache.flex.mdl
      *  @productversion FlexJS 0.8
      */
     COMPILE::SWF
-	public class RadioButton extends UIButtonBase implements IStrand
+	public class RadioButton extends UIButtonBase
 	{
         /**
 		 *  constructor.

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/a77e4248/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Switch.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Switch.as b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Switch.as
index abe0290..edf9a8b 100644
--- a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Switch.as
+++ b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Switch.as
@@ -82,7 +82,7 @@ package org.apache.flex.mdl
      *  @playerversion AIR 2.6
      *  @productversion FlexJS 0.8
      */
-    public class Switch extends TextButton implements IStrand, IEventDispatcher, IUIBase
+    public class Switch extends TextButton
     {
         /**
          *  Constructor.

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/a77e4248/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderThumbView.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderThumbView.as b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderThumbView.as
index 3c1a1c7..4bb77c3 100644
--- a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderThumbView.as
+++ b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderThumbView.as
@@ -39,7 +39,7 @@ package org.apache.flex.mdl.beads.views
 	 *  @playerversion AIR 2.6
 	 *  @productversion FlexJS 0.8
 	 */
-	public class SliderThumbView extends BeadViewBase implements IBeadView
+	public class SliderThumbView extends BeadViewBase
 	{
 		/**
 		 *  constructor.

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/a77e4248/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderTrackView.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderTrackView.as b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderTrackView.as
index 2dbce66..e46bb4f 100644
--- a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderTrackView.as
+++ b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderTrackView.as
@@ -39,7 +39,7 @@ package org.apache.flex.mdl.beads.views
 	 *  @playerversion AIR 2.6
 	 *  @productversion FlexJS 0.8
 	 */
-	public class SliderTrackView extends BeadViewBase implements IBeadView
+	public class SliderTrackView extends BeadViewBase
 	{
 		/**
 		 *  constructor.

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/a77e4248/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderView.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderView.as b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderView.as
index 0b2e13d..49799e0 100644
--- a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderView.as
+++ b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/views/SliderView.as
@@ -41,7 +41,7 @@ package org.apache.flex.mdl.beads.views
 	 *  @playerversion AIR 2.6
 	 *  @productversion FlexJS 0.8
 	 */
-	public class SliderView extends BeadViewBase implements ISliderView, IBeadView
+	public class SliderView extends BeadViewBase implements ISliderView
 	{
 		/**
 		 *  constructor.


[09/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - again

Posted by ha...@apache.org.
again


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/c003dca9
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/c003dca9
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/c003dca9

Branch: refs/heads/refactor-strand
Commit: c003dca913cc70ee04a43563db1ad260ea9feb2a
Parents: 6067389
Author: Harbs <ha...@in-tools.com>
Authored: Sun Jul 16 00:09:54 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Sun Jul 16 00:09:54 2017 +0300

----------------------------------------------------------------------
 .../src/main/flex/org/apache/flex/utils/MockContentView.as       | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c003dca9/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockContentView.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockContentView.as b/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockContentView.as
index 0cad68f..ffef059 100644
--- a/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockContentView.as
+++ b/frameworks/projects/Effects/src/main/flex/org/apache/flex/utils/MockContentView.as
@@ -142,15 +142,13 @@ package org.apache.flex.utils
 			return null;
 		}
 
-		public function registerBead(bead:IBead):void
-		{
-		}
 
 		public function addBead(bead:IBead):void
 		{
 			// TODO Auto Generated method stub
 
 		}
+		public function registerBead(bead:IBead):void{}
 		public function addBeads():void{}
 
 		public function getBeadByType(classOrInterface:Class):IBead


Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

Posted by Harbs <ha...@gmail.com>.
Not surprised. I still have quite a bit to do before I’d expect it to build.


> On Jul 18, 2017, at 7:20 AM, piotrz <pi...@gmail.com> wrote:
> 
> Hi Harbs,
> 
> I've created pipelines for your strand-work branch. Just run the build and
> it failed [1].
> 
> [1]
> https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/feature%252Fstrand-work/2/console
> 
> Thanks,
> Piotr
> 
> 
> 
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-01-10-git-commit-flex-asjs-refs-heads-refactor-strand-Core-changes-to-IStrand-tp63279p63363.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

Posted by Harbs <ha...@gmail.com>.
Never mind. On JS it’s defined in the superclasses.

> On Aug 8, 2017, at 11:56 PM, Harbs <ha...@gmail.com> wrote:
> 
> I’m not sure I understand how CreateJS passes at all. Application.as (in CreateJS) has a call to addBead() and I don’t see the function defined anywhere…
> 
>> On Jul 18, 2017, at 7:20 AM, piotrz <pi...@gmail.com> wrote:
>> 
>> Hi Harbs,
>> 
>> I've created pipelines for your strand-work branch. Just run the build and
>> it failed [1].
>> 
>> [1]
>> https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/feature%252Fstrand-work/2/console
>> 
>> Thanks,
>> Piotr
>> 
>> 
>> 
>> -----
>> Apache Flex PMC
>> piotrzarzycki21@gmail.com
>> --
>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-01-10-git-commit-flex-asjs-refs-heads-refactor-strand-Core-changes-to-IStrand-tp63279p63363.html
>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
> 


Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

Posted by Harbs <ha...@gmail.com>.
I’m not sure I understand how CreateJS passes at all. Application.as (in CreateJS) has a call to addBead() and I don’t see the function defined anywhere…

> On Jul 18, 2017, at 7:20 AM, piotrz <pi...@gmail.com> wrote:
> 
> Hi Harbs,
> 
> I've created pipelines for your strand-work branch. Just run the build and
> it failed [1].
> 
> [1]
> https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/feature%252Fstrand-work/2/console
> 
> Thanks,
> Piotr
> 
> 
> 
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-01-10-git-commit-flex-asjs-refs-heads-refactor-strand-Core-changes-to-IStrand-tp63279p63363.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

Posted by piotrz <pi...@gmail.com>.
Hi Harbs,

I've created pipelines for your strand-work branch. Just run the build and
it failed [1].

[1]
https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Pipeline/job/feature%252Fstrand-work/2/console

Thanks,
Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-01-10-git-commit-flex-asjs-refs-heads-refactor-strand-Core-changes-to-IStrand-tp63279p63363.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

Posted by Harbs <ha...@gmail.com>.
I renamed the branch.

> On Jul 16, 2017, at 12:11 PM, piotrz <pi...@gmail.com> wrote:
> 
> You are doing core changes. Monitoring it on jenkins would be great. Apart of
> that I can check some examples without building it locally.
> 
> Piotr
> 
> 
> 
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-01-10-git-commit-flex-asjs-refs-heads-refactor-strand-Core-changes-to-IStrand-tp63279p63289.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

Posted by piotrz <pi...@gmail.com>.
You are doing core changes. Monitoring it on jenkins would be great. Apart of
that I can check some examples without building it locally.

Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-01-10-git-commit-flex-asjs-refs-heads-refactor-strand-Core-changes-to-IStrand-tp63279p63289.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

Posted by Harbs <ha...@gmail.com>.
I was thinking of doing it in feature, but I did not know if it made sense. I’m not opposed to doing so.

> On Jul 16, 2017, at 10:31 AM, piotrz <pi...@gmail.com> wrote:
> 
> Hi Harbs,
> 
> Is it possible move this branch to existing folder feature? Once you do this
> I can creat same branch for Falcon and Typedefs - It will be then
> automatically build on Maven pipelines.
> 
> Thanks, 
> Piotr
> 
> 
> 
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-01-10-git-commit-flex-asjs-refs-heads-refactor-strand-Core-changes-to-IStrand-tp63279p63286.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.


Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

Posted by piotrz <pi...@gmail.com>.
Hi Harbs,

Is it possible move this branch to existing folder feature? Once you do this
I can creat same branch for Falcon and Typedefs - It will be then
automatically build on Maven pipelines.

Thanks, 
Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-01-10-git-commit-flex-asjs-refs-heads-refactor-strand-Core-changes-to-IStrand-tp63279p63286.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

Posted by Harbs <ha...@gmail.com>.
Here’s the first stab at my experiment.

I still need to audit the classes and figure out where addBeads() needs to be called.
Then I need to go through some tests and check how they behave…

Once I’m there, we can discuss…

> On Jul 16, 2017, at 12:35 AM, harbs@apache.org wrote:
> 
> Repository: flex-asjs
> Updated Branches:
>  refs/heads/refactor-strand [created] 41e30e2cf
> 
> 
> Core changes to IStrand
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/80580936
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/80580936
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/80580936
> 
> Branch: refs/heads/refactor-strand
> Commit: 80580936bf28455f7c3573ca96ee14dff396936c
> Parents: dd4672b
> Author: Harbs <ha...@in-tools.com>
> Authored: Sat Jul 15 23:57:20 2017 +0300
> Committer: Harbs <ha...@in-tools.com>
> Committed: Sat Jul 15 23:57:20 2017 +0300
> 
> ----------------------------------------------------------------------
> .../flex/org/apache/flex/core/ElementWrapper.as | 61 ++++++++++++++++++++
> .../main/flex/org/apache/flex/core/IStrand.as   | 24 ++++++++
> .../main/flex/org/apache/flex/core/Strand.as    | 29 ++++++++++
> .../apache/flex/utils/MXMLDataInterpreter.as    |  4 +-
> 4 files changed, 116 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/80580936/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
> index b744edb..53785ac 100644
> --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
> +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/ElementWrapper.as
> @@ -60,11 +60,29 @@ package org.apache.flex.core
>             _element = value;
>         }
> 
> +        private var beads:Array;
> +
>         protected var _beads:Vector.<IBead>;
> 
>         //--------------------------------------
>         //   Function
>         //--------------------------------------
> +
> +        /**
> +         *  @copy org.apache.flex.core.IStrand#registerBead()
> +         *  
> +         *  @langversion 3.0
> +         *  @playerversion Flash 10.2
> +         *  @playerversion AIR 2.6
> +         *  @productversion FlexJS 0.9
> +         */
> +        public function registerBead(bead:IBead):void
> +        {
> +            if(beads)
> +                beads.push(bead);
> +            else
> +                beads = [bead];
> +        }
> 
>         /**
>          * @param bead The new bead.
> @@ -79,6 +97,19 @@ package org.apache.flex.core
>             _beads.push(bead);
>             bead.strand = this;
>         }
> +
> +        /**
> +         *  @copy org.apache.flex.core.IStrand#addBeads()
> +         *  
> +         *  @langversion 3.0
> +         *  @playerversion Flash 10.2
> +         *  @playerversion AIR 2.6
> +         *  @productversion FlexJS 0.9
> +         */
> +        public function addBeads():void
> +        {
> +            addBeadsToStrand(this,beads);
> +        }
> 
>         /**
>          * @param classOrInterface The requested bead type.
> @@ -228,6 +259,7 @@ package org.apache.flex.core
>             _element = value;
>         }
> 
> +        private var beads:Array;
> 
> 		protected var _beads:Vector.<IBead>;
> 
> @@ -236,6 +268,22 @@ package org.apache.flex.core
> 		//--------------------------------------
> 
>         /**
> +         *  @copy org.apache.flex.core.IStrand#registerBead()
> +         *  
> +         *  @langversion 3.0
> +         *  @playerversion Flash 10.2
> +         *  @playerversion AIR 2.6
> +         *  @productversion FlexJS 0.9
> +         */
> +        public function registerBead(bead:IBead):void
> +        {
> +            if(beads)
> +                beads.push(bead);
> +            else
> +                beads = [bead];
> +        }
> +
> +        /**
>          * @param bead The new bead.
>          */
> 		public function addBead(bead:IBead):void
> @@ -250,6 +298,19 @@ package org.apache.flex.core
> 		}
> 
>         /**
> +         *  @copy org.apache.flex.core.IStrand#addBeads()
> +         *  
> +         *  @langversion 3.0
> +         *  @playerversion Flash 10.2
> +         *  @playerversion AIR 2.6
> +         *  @productversion FlexJS 0.9
> +         */
> +        public function addBeads():void
> +        {
> +            addBeadsToStrand(this,beads);
> +        }
> +
> +        /**
>          * @param classOrInterface The requested bead type.
>          * @return The bead.
>          */
> 
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/80580936/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IStrand.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IStrand.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IStrand.as
> index b6e8b20..a60e340 100644
> --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IStrand.as
> +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IStrand.as
> @@ -37,6 +37,18 @@ package org.apache.flex.core
> 	public interface IStrand
> 	{
>         /**
> +         *  Registers a bead to be add to the strand.
> +         *
> +         *  @param bead The bead to be added.
> +         * 
> +         *  @langversion 3.0
> +         *  @playerversion Flash 10.2
> +         *  @playerversion AIR 2.6
> +         *  @productversion FlexJS 0.9
> +         */
> +		function registerBead(bead:IBead):void;
> +
> +        /**
>          *  Add a bead to the strand.
>          *
>          *  @param bead The bead to be added.
> @@ -47,6 +59,18 @@ package org.apache.flex.core
>          *  @productversion FlexJS 0.0
>          */
> 		function addBead(bead:IBead):void;
> +
> +        /**
> +         *  Add the beads registered to the strand.
> +         *
> +         *  @param bead The bead to be added.
> +         * 
> +         *  @langversion 3.0
> +         *  @playerversion Flash 10.2
> +         *  @playerversion AIR 2.6
> +         *  @productversion FlexJS 0.9
> +         */
> +		function addBeads():void;
> 
>         /**
>          *  Find a bead on the strand.
> 
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/80580936/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Strand.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Strand.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Strand.as
> index b0318d6..f4953fa 100644
> --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Strand.as
> +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/Strand.as
> @@ -120,6 +120,22 @@ package org.apache.flex.core
> 		private var _beads:Vector.<IBead>;
> 
>         /**
> +         *  @copy org.apache.flex.core.IStrand#registerBead()
> +         *  
> +         *  @langversion 3.0
> +         *  @playerversion Flash 10.2
> +         *  @playerversion AIR 2.6
> +         *  @productversion FlexJS 0.9
> +         */
> +        public function registerBead(bead:IBead):void
> +        {
> +            if(beads)
> +                beads.push(bead);
> +            else
> +                beads = [bead];
> +        }
> +
> +        /**
>          *  @copy org.apache.flex.core.IStrand#addBead()
>          *  
>          *  @langversion 3.0
> @@ -136,6 +152,19 @@ package org.apache.flex.core
> 				_model = bead as IBeadModel;
> 			bead.strand = this;
> 		}
> +
> +        /**
> +         *  @copy org.apache.flex.core.IStrand#addBeads()
> +         *  
> +         *  @langversion 3.0
> +         *  @playerversion Flash 10.2
> +         *  @playerversion AIR 2.6
> +         *  @productversion FlexJS 0.9
> +         */
> +        public function addBeads():void
> +        {
> +            addBeadsToStrand(this,beads);
> +        }
> 		
>         /**
>          *  @copy org.apache.flex.core.IStrand#getBeadByType()
> 
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/80580936/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/MXMLDataInterpreter.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/MXMLDataInterpreter.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/MXMLDataInterpreter.as
> index 6f24181..704503d 100644
> --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/MXMLDataInterpreter.as
> +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/MXMLDataInterpreter.as
> @@ -191,8 +191,8 @@ public class MXMLDataInterpreter
>             else if (simple == false)
>                 value = generateMXMLObject(document, value as Array);
>             comp[name] = value;
> -            if (value is IBead && comp is IStrand)
> -                IStrand(comp).addBead(value as IBead);
> +            // if (value is IBead && comp is IStrand)
> +            //     IStrand(comp).addBead(value as IBead);
>         }
>         var beadOffset:int = i + (m - 1) * 3;
>         //if (beadOffset >= -1)
>