You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/21 04:01:51 UTC
[GitHub] [incubator-hudi] dengziming opened a new pull request #1543: HUDI-821:Fix the wrong annotation of JCommander IStringConverter
dengziming opened a new pull request #1543:
URL: https://github.com/apache/incubator-hudi/pull/1543
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
Please refer to https://github.com/cbeust/jcommander/issues/253.
If you define a list as argument to be parsed with an IStringConverter, JCommander will create a List<List<String>> instead of a List<String>.
## Brief change log
we should change `converter = TransformersConverter.class` to `converter = StringConverter.class, listConverter = TransformersConverter.class`.
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] bvaradar commented on issue #1543: [HUDI-821]:Fix the wrong annotation of JCommander IStringConverter
Posted by GitBox <gi...@apache.org>.
bvaradar commented on issue #1543:
URL: https://github.com/apache/incubator-hudi/pull/1543#issuecomment-616939586
@dengziming : THis is addressing the same issue as https://github.com/apache/incubator-hudi/pull/1525. Do you have any specific comments/concerns with https://github.com/apache/incubator-hudi/pull/1525 . Feel free to review https://github.com/apache/incubator-hudi/pull/1525 too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] dengziming commented on issue #1543: [HUDI-821]:Fix the wrong annotation of JCommander IStringConverter
Posted by GitBox <gi...@apache.org>.
dengziming commented on issue #1543:
URL: https://github.com/apache/incubator-hudi/pull/1543#issuecomment-617549092
@bvaradar Thank you for your comment, this is a redundant work and I will close it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-io commented on issue #1543: [HUDI-821]:Fix the wrong annotation of JCommander IStringConverter
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1543:
URL: https://github.com/apache/incubator-hudi/pull/1543#issuecomment-616990309
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1543?src=pr&el=h1) Report
> Merging [#1543](https://codecov.io/gh/apache/incubator-hudi/pull/1543?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/ddd105bb3119174b613c6917ee25795f2939f430&el=desc) will **decrease** coverage by `0.69%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1543?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1543 +/- ##
============================================
- Coverage 72.35% 71.66% -0.70%
Complexity 294 294
============================================
Files 374 378 +4
Lines 16377 16535 +158
Branches 1650 1672 +22
============================================
Hits 11849 11849
- Misses 3797 3954 +157
- Partials 731 732 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1543?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...i/common/table/timeline/HoodieDefaultTimeline.java](https://codecov.io/gh/apache/incubator-hudi/pull/1543/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL0hvb2RpZURlZmF1bHRUaW1lbGluZS5qYXZh) | `92.30% <ø> (-0.12%)` | `0.00 <0.00> (ø)` | |
| [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1543/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `78.13% <ø> (ø)` | `11.00 <0.00> (ø)` | |
| [...s/deltastreamer/HoodieMultiTableDeltaStreamer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1543/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllTXVsdGlUYWJsZURlbHRhU3RyZWFtZXIuamF2YQ==) | `78.39% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...di/hadoop/realtime/HoodieRealtimeRecordReader.java](https://codecov.io/gh/apache/incubator-hudi/pull/1543/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZVJlYWx0aW1lUmVjb3JkUmVhZGVyLmphdmE=) | `70.00% <0.00%> (-14.22%)` | `0.00% <0.00%> (ø%)` | |
| [...hudi/hadoop/hive/HoodieCombineHiveInputFormat.java](https://codecov.io/gh/apache/incubator-hudi/pull/1543/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL2hpdmUvSG9vZGllQ29tYmluZUhpdmVJbnB1dEZvcm1hdC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../hadoop/realtime/RealtimeUnmergedRecordReader.java](https://codecov.io/gh/apache/incubator-hudi/pull/1543/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL1JlYWx0aW1lVW5tZXJnZWRSZWNvcmRSZWFkZXIuamF2YQ==) | `96.96% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...apache/hudi/common/util/collection/ArrayUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1543/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvY29sbGVjdGlvbi9BcnJheVV0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...di/hadoop/hive/HoodieCombineRealtimeFileSplit.java](https://codecov.io/gh/apache/incubator-hudi/pull/1543/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL2hpdmUvSG9vZGllQ29tYmluZVJlYWx0aW1lRmlsZVNwbGl0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...op/realtime/HoodieCombineRealtimeRecordReader.java](https://codecov.io/gh/apache/incubator-hudi/pull/1543/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUNvbWJpbmVSZWFsdGltZVJlY29yZFJlYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...di/hadoop/hive/HoodieCombineRealtimeHiveSplit.java](https://codecov.io/gh/apache/incubator-hudi/pull/1543/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL2hpdmUvSG9vZGllQ29tYmluZVJlYWx0aW1lSGl2ZVNwbGl0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-hudi/pull/1543/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1543?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1543?src=pr&el=footer). Last update [2a2f31d...1a6841f](https://codecov.io/gh/apache/incubator-hudi/pull/1543?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] bvaradar edited a comment on issue #1543: [HUDI-821]:Fix the wrong annotation of JCommander IStringConverter
Posted by GitBox <gi...@apache.org>.
bvaradar edited a comment on issue #1543:
URL: https://github.com/apache/incubator-hudi/pull/1543#issuecomment-616939586
@dengziming : Thanks for your contribution. This is addressing the same issue as https://github.com/apache/incubator-hudi/pull/1525. Do you have any specific comments/concerns with https://github.com/apache/incubator-hudi/pull/1525 . Feel free to review https://github.com/apache/incubator-hudi/pull/1525 too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org