You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/04/07 11:37:03 UTC

[GitHub] [incubator-inlong] healchow commented on a diff in pull request #3567: [INLONG-3565][Manager] Unified the interface for flink plugin

healchow commented on code in PR #3567:
URL: https://github.com/apache/incubator-inlong/pull/3567#discussion_r845028146


##########
inlong-manager/manager-plugins/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkService.java:
##########
@@ -177,7 +144,7 @@ public JobStatus getJobStatus(String jobId) {
             return status;
 
         } catch (Exception e) {
-            e.printStackTrace();
+            log.error("get job status error", e.getMessage());

Review Comment:
   In the error log, we need to print all stack traces of exception, so it is recommended to use `log.error("get job status error: ", e);`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org