[GitHub] [superset] john-bodley commented on a diff in pull request #14736: fix(docker): superset permissions and firefox config

[GitBox <gi...@apache.org>]

john-bodley commented on code in PR #14736:
URL: https://github.com/apache/superset/pull/14736#discussion_r893719835


##########
superset/config.py:
##########
@@ -1027,16 +1027,12 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC(
 WEBDRIVER_AUTH_FUNC = None
 
 # Any config options to be passed as-is to the webdriver
-WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {}
+WEBDRIVER_CONFIGURATION: Dict[Any, Any] = {"service_log_path": "/dev/null"}
 
 # Additional args to be passed as arguments to the config object
 # Note: these options are Chrome-specific. For FF, these should
 # only include the "--headless" arg
-WEBDRIVER_OPTION_ARGS = [
-    "--force-device-scale-factor=2.0",
-    "--high-dpi-support=2.0",
-    "--headless",
-]
+WEBDRIVER_OPTION_ARGS = ["--headless", "--marionette"]

Review Comment:
   @dpgaspar should this just be `["--headless"]` given that the `WEBDRIVER_TYPE` is defaulted to `firefox`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org