You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ch...@apache.org on 2019/07/01 12:19:50 UTC
[qpid-dispatch] branch master updated (3603fd5 -> c46fe79)
This is an automated email from the ASF dual-hosted git repository.
chug pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git.
from 3603fd5 NO-JIRA: delete duplicate line of code
add 7094efc NO-JIRA - Fix typo in man/qdstat.8.adoc
new c46fe79 DISPATCH-1379: Performance improvement in message receive
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
docs/man/qdstat.8.adoc | 4 ++--
src/message.c | 17 ++++++++++-------
2 files changed, 12 insertions(+), 9 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org
[qpid-dispatch] 01/01: DISPATCH-1379: Performance improvement in
message receive
Posted by ch...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
chug pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git
commit c46fe7911becba624cd9ba7713ace2f02f63febe
Author: Chuck Rolke <ch...@apache.org>
AuthorDate: Mon Jul 1 08:02:05 2019 -0400
DISPATCH-1379: Performance improvement in message receive
* Eliminate three function calls per message
* Refer to consecutive memory locations in a more cache-friendy way
* Free unused buffer outside of content lock
---
src/message.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/src/message.c b/src/message.c
index 2335fed..785866b 100644
--- a/src/message.c
+++ b/src/message.c
@@ -887,13 +887,13 @@ qd_message_t *qd_message()
return 0;
DEQ_ITEM_INIT(msg);
+ msg->cursor.buffer = 0;
+ msg->cursor.cursor = 0;
+ msg->sent_depth = QD_DEPTH_NONE;
DEQ_INIT(msg->ma_to_override);
DEQ_INIT(msg->ma_trace);
DEQ_INIT(msg->ma_ingress);
msg->ma_phase = 0;
- msg->sent_depth = QD_DEPTH_NONE;
- msg->cursor.buffer = 0;
- msg->cursor.cursor = 0;
msg->send_complete = false;
msg->tag_sent = false;
msg->is_fanout = false;
@@ -1265,9 +1265,8 @@ qd_message_t *qd_message_receive(pn_delivery_t *delivery)
//
if (!msg) {
msg = (qd_message_pvt_t*) qd_message();
- qd_link_t *qdl = (qd_link_t *)pn_link_get_context(link);
qd_connection_t *qdc = qd_link_connection(qdl);
- set_safe_ptr_qd_link_t(pn_link_get_context(link), &msg->content->input_link_sp);
+ set_safe_ptr_qd_link_t(qdl, &msg->content->input_link_sp);
msg->strip_annotations_in = qd_connection_strip_annotations_in(qdc);
pn_record_def(record, PN_DELIVERY_CTX, PN_WEAKREF);
pn_record_set(record, PN_DELIVERY_CTX, (void*) msg);
@@ -1277,7 +1276,7 @@ qd_message_t *qd_message_receive(pn_delivery_t *delivery)
// The discard flag indicates we should keep reading the input stream
// but not process the message for delivery.
//
- if (qd_message_is_discard((qd_message_t*)msg)) {
+ if (msg->content->discard) {
return discard_receive(delivery, link, (qd_message_t *)msg);
}
@@ -1306,6 +1305,7 @@ qd_message_t *qd_message_receive(pn_delivery_t *delivery)
if (at_eos || recv_error) {
// Message is complete
+ qd_buffer_t * pending_free = 0; // free empty pending buffer outside of lock
LOCK(content->lock);
{
// Append last buffer if any with data
@@ -1317,7 +1317,7 @@ qd_message_t *qd_message_receive(pn_delivery_t *delivery)
content->pending);
} else {
// pending buffer is empty
- qd_buffer_free(content->pending);
+ pending_free = content->pending;
}
content->pending = 0;
} else {
@@ -1332,6 +1332,9 @@ qd_message_t *qd_message_receive(pn_delivery_t *delivery)
pn_record_set(record, PN_DELIVERY_CTX, 0);
}
UNLOCK(content->lock);
+ if (!!pending_free) {
+ qd_buffer_free(content->pending);
+ }
break;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org