You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/02 08:19:57 UTC
[GitHub] [iotdb] RYH61 opened a new pull request, #6866: [IOTDB-3758] support merge in new cluster
RYH61 opened a new pull request, #6866:
URL: https://github.com/apache/iotdb/pull/6866
MERGE (ON (LOCAL | CLUSTER))?
FULL MERGE (ON (LOCAL | CLUSTER))?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] RYH61 commented on a diff in pull request #6866: [IOTDB-3758] support merge in new cluster
Posted by GitBox <gi...@apache.org>.
RYH61 commented on code in PR #6866:
URL: https://github.com/apache/iotdb/pull/6866#discussion_r935491269
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/parser/ASTVisitor.java:
##########
@@ -2325,6 +2314,36 @@ private Pair<Long, Long> calcOperatorInterval(QueryFilter queryFilter) {
}
}
+ // Merge
+
Review Comment:
fix~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a diff in pull request #6866: [IOTDB-3758] support merge in new cluster
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on code in PR #6866:
URL: https://github.com/apache/iotdb/pull/6866#discussion_r935434492
##########
server/src/main/java/org/apache/iotdb/db/service/thrift/impl/DataNodeInternalRPCServiceImpl.java:
##########
@@ -483,9 +485,19 @@ public TSStatus invalidatePermissionCache(TInvalidatePermissionCacheReq req) {
return RpcUtils.getStatus(TSStatusCode.INVALIDATE_PERMISSION_CACHE_ERROR);
}
+ @Override
+ public TSStatus merge(TMergeReq req) throws TException {
+ try {
+ storageEngine.mergeAll();
Review Comment:
why merge all ? req does noet used?
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/parser/ASTVisitor.java:
##########
@@ -2325,6 +2314,36 @@ private Pair<Long, Long> calcOperatorInterval(QueryFilter queryFilter) {
}
}
+ // Merge
+
Review Comment:
remove space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on pull request #6866: [IOTDB-3758] support merge in new cluster
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on PR #6866:
URL: https://github.com/apache/iotdb/pull/6866#issuecomment-1202345742
add IT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan merged pull request #6866: [IOTDB-3758] support merge in new cluster
Posted by GitBox <gi...@apache.org>.
neuyilan merged PR #6866:
URL: https://github.com/apache/iotdb/pull/6866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] RYH61 commented on a diff in pull request #6866: [IOTDB-3758] support merge in new cluster
Posted by GitBox <gi...@apache.org>.
RYH61 commented on code in PR #6866:
URL: https://github.com/apache/iotdb/pull/6866#discussion_r935492042
##########
server/src/main/java/org/apache/iotdb/db/service/thrift/impl/DataNodeInternalRPCServiceImpl.java:
##########
@@ -483,9 +485,19 @@ public TSStatus invalidatePermissionCache(TInvalidatePermissionCacheReq req) {
return RpcUtils.getStatus(TSStatusCode.INVALIDATE_PERMISSION_CACHE_ERROR);
}
+ @Override
+ public TSStatus merge(TMergeReq req) throws TException {
+ try {
+ storageEngine.mergeAll();
Review Comment:
It's not used here. I've removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org