You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/02/02 00:14:39 UTC
Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/
-----------------------------------------------------------
(Updated Feb. 1, 2018, 4:14 p.m.)
Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-6713
https://issues.apache.org/jira/browse/MESOS-6713
Repository: mesos
Description
-------
This commit enables the unit tests found in `slave_recovery_tests.cpp`
to test agent recovery on Windows.
Diffs (updated)
-----
src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5
src/tests/slave_recovery_tests.cpp 77aa60c953bd0769eaba05f001755e4cec9ba028
Diff: https://reviews.apache.org/r/65408/diff/2/
Changes: https://reviews.apache.org/r/65408/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/#review196956
-----------------------------------------------------------
Ship it!
Couple of comment tweaks for you to do before committing.
src/tests/slave_recovery_tests.cpp
Lines 3258 (patched)
<https://reviews.apache.org/r/65408/#comment276944>
s/no/not/
src/tests/slave_recovery_tests.cpp
Lines 4449 (patched)
<https://reviews.apache.org/r/65408/#comment276945>
We stopped putting the extra `!` in this `#endif`s a while ago.
(There are only a few places left which haven't been cleaned up yet).
src/tests/slave_recovery_tests.cpp
Lines 4496 (patched)
<https://reviews.apache.org/r/65408/#comment276946>
Ditto about the `!`.
src/tests/slave_recovery_tests.cpp
Lines 4729-4730 (patched)
<https://reviews.apache.org/r/65408/#comment276947>
s/default Windows memory/default Windows isolators/
- Joseph Wu
On Feb. 1, 2018, 4:14 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65408/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2018, 4:14 p.m.)
>
>
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-6713
> https://issues.apache.org/jira/browse/MESOS-6713
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit enables the unit tests found in `slave_recovery_tests.cpp`
> to test agent recovery on Windows.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5
> src/tests/slave_recovery_tests.cpp 77aa60c953bd0769eaba05f001755e4cec9ba028
>
>
> Diff: https://reviews.apache.org/r/65408/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/#review197043
-----------------------------------------------------------
Ship it!
Ship It!
- Akash Gupta
On Feb. 2, 2018, 12:14 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65408/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 12:14 a.m.)
>
>
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-6713
> https://issues.apache.org/jira/browse/MESOS-6713
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit enables the unit tests found in `slave_recovery_tests.cpp`
> to test agent recovery on Windows.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5
> src/tests/slave_recovery_tests.cpp 77aa60c953bd0769eaba05f001755e4cec9ba028
>
>
> Diff: https://reviews.apache.org/r/65408/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65408/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 11:53 a.m.)
Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
Bugs: MESOS-6713
https://issues.apache.org/jira/browse/MESOS-6713
Repository: mesos
Description
-------
This commit enables the unit tests found in `slave_recovery_tests.cpp`
to test agent recovery on Windows.
Diffs (updated)
-----
src/tests/CMakeLists.txt 6f1c67a6b4003ada1a0635a68fb7471895a2a6f5
src/tests/slave_recovery_tests.cpp 77aa60c953bd0769eaba05f001755e4cec9ba028
Diff: https://reviews.apache.org/r/65408/diff/3/
Changes: https://reviews.apache.org/r/65408/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer