You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/10 06:35:34 UTC

[GitHub] [spark] panbingkun opened a new pull request, #36493: [SPARK-38739][SQL][TESTS] Test the error class: INVALID_SYNTAX_FOR_CAST

panbingkun opened a new pull request, #36493:
URL: https://github.com/apache/spark/pull/36493

   ## What changes were proposed in this pull request?
   This PR aims to add a test for the error class INVALID_SYNTAX_FOR_CAST to `QueryExecutionErrors`.
   
   
   - the error class INVALID_INPUT_SYNTAX_FOR_NUMERIC_TYPE not exist!
   - removed as no longer used method: 
   def invalidInputSyntaxForNumericError(
         e: NumberFormatException,
         errorContext: String): NumberFormatException = {
       new NumberFormatException(s"${e.getMessage}. To return NULL instead, use 'try_cast'. " +
        s"If necessary set ${SQLConf.ANSI_ENABLED.key} to false to bypass this error." + errorContext)
   
   ### Why are the changes needed?
   The changes improve test coverage, and document expected error messages in tests.
   
   ### Does this PR introduce any user-facing change?
   No
   
   ### How was this patch tested?
   By running new test:
   ```
   $ build/sbt "sql/testOnly *QueryExecutionErrorsSuite*"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #36493: [SPARK-38739][SQL][TESTS] Test the error class: INVALID_SYNTAX_FOR_CAST

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36493:
URL: https://github.com/apache/spark/pull/36493#issuecomment-1123146603

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #36493: [SPARK-38739][SQL][TESTS] Test the error class: INVALID_SYNTAX_FOR_CAST

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #36493: [SPARK-38739][SQL][TESTS] Test the error class: INVALID_SYNTAX_FOR_CAST
URL: https://github.com/apache/spark/pull/36493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org