[jira] Commented: (TRINIDAD-1415) allow :alias support to merge in -tr- custom skin properties as well

["Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TRINIDAD-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908235#action_12908235 ] 

Jeanne Waldman commented on TRINIDAD-1415:
------------------------------------------

After merging this into trunk again, I see that this does work for the simplest case, but not for many other test cases.
Now that TRINIDAD-17 is implemented (-tr-rule-ref for icons), I would like to investigate if the skinning properties can be resolved in the same way. Store the skin properties on the Node. When we generate the css file for a particular StyleContext, we should be able to store resolved skin properties for that StyleContext. This is similar to this patch, but we wouldn't do much work in the SkinStyleSheetParserUtils. We'd do more work in StyleSheetDocument.
I will try to get investigate in the next couple of weeks if my schedule allows, since I fixed TRINIDAD-17 recently.

test cases that must work:

test: (simplest test case works in the previous patch)
.AFShowLastItem:alias {-tr-show-last-item: false;}
af|breadCrumbs {-tr-rule-ref: selector(".AFShowLastItem:alias");}

test:
@agent gecko {
.AFShowLastItem:alias {-tr-show-last-item: false;}
}
af|breadCrumbs {-tr-rule-ref: selector(".AFShowLastItem:alias");}

test:
af|someOtherSelector {-tr-show-last-item: false;}
af|breadCrumbs {-tr-rule-ref: selector("af|someOtherSelector");}

test:
.AFFoo:alias {-tr-show-last-item: false;}
.AFBar:alias {color: red; background-color: blue}
.AFCombined:alias {
-tr-rule-ref: selector(".AFFoo:alias");
-tr-rule-ref: selector(".AFBar:alias");
}

af|breadCrumbs {
-tr-rule-ref: selector(".AFCombined:alias");
}

Test multiple skins, so alias is in one skin and its include is in another

Test different locales as well

Test the browser in different languages, since we had an error when the icons were in different languages when there wasn't an icon for that language.

> allow :alias support to merge in -tr- custom skin properties as well
> --------------------------------------------------------------------
>
>                 Key: TRINIDAD-1415
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1415
>             Project: MyFaces Trinidad
>          Issue Type: New Feature
>          Components: Skinning
>    Affects Versions:  1.2.11-core
>            Reporter: Jeanne Waldman
>            Assignee: Jeanne Waldman
>         Attachments: 1415Reformatted.patch, tr_properties_in_alias.patch
>
>
> .AFSomeAlias:alias {-tr-my-property: red}
> af|foo {-tr-rule-ref: selector(".AFSomeAlias:alias")} 
> should resolve into:
> af|foo {-tr-my-property: red}
> so from the renderer you can say, getSkin().getProperty("af|foot-tr-my-property") and it would return red.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.