You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/11 07:14:08 UTC

[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #154: [WIP] VPC: Add Internal LB form and Assign VM to LB rule form

Pearl1594 opened a new pull request #154: [WIP] VPC: Add Internal LB form and Assign VM to LB rule form
URL: https://github.com/apache/cloudstack-primate/pull/154
 
 
   -> Added collapsable view for Internal LB, Public IPs, SNAT and VMs
   -> Form for assigning VMs to Internal LBs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack-primate] rhtyd commented on issue #154: VPC: Add Internal LB form and Assign VM to LB rule form

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #154: VPC: Add Internal LB form and Assign VM to LB rule form
URL: https://github.com/apache/cloudstack-primate/pull/154#issuecomment-586897679
 
 
   @Pearl1594 issues with the PR, please submit another PR:
   - Use a-table instead of a-list especially for forms wherever pagination must be used
   - See my changes, use of correct APIs etc.
   - Before handing over for review/testing, do testing yourself of the end-to-end feature

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack-primate] Pearl1594 commented on issue #154: [WIP] VPC: Add Internal LB form and Assign VM to LB rule form

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on issue #154: [WIP] VPC: Add Internal LB form and Assign VM to LB rule form
URL: https://github.com/apache/cloudstack-primate/pull/154#issuecomment-586202478
 
 
   @rhtyd  I've added the Assigned VMs tab

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack-primate] rhtyd merged pull request #154: VPC: Add Internal LB form and Assign VM to LB rule form

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #154: VPC: Add Internal LB form and Assign VM to LB rule form
URL: https://github.com/apache/cloudstack-primate/pull/154
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack-primate] rhtyd commented on issue #154: [WIP] VPC: Add Internal LB form and Assign VM to LB rule form

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #154: [WIP] VPC: Add Internal LB form and Assign VM to LB rule form
URL: https://github.com/apache/cloudstack-primate/pull/154#issuecomment-586143106
 
 
   Please follow my changes/fixes @Pearl1594, the only remaining item is the assigned VMs tab
   
   ![Screenshot from 2020-02-14 13-30-58](https://user-images.githubusercontent.com/95203/74512444-4866ad80-4f2e-11ea-90c2-b021fcc272af.png)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services