[GitHub] [iceberg] pvary commented on a change in pull request #2340: Hive: Remove unnecessary SerializationUtil.serializeToBase64 from HiveIcebergStorageHandler.overlayTableProperties

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2340:
URL: https://github.com/apache/iceberg/pull/2340#discussion_r595198985



##########
File path: core/src/main/java/org/apache/iceberg/StaticTableOperations.java
##########
@@ -31,15 +31,23 @@
 public class StaticTableOperations implements TableOperations {
   private final TableMetadata staticMetadata;
   private final FileIO io;
+  private final LocationProvider locationProvider;
 
   /**
    * Creates a StaticTableOperations tied to a specific static version of the TableMetadata
    */
   public StaticTableOperations(String metadataFileLocation, FileIO io) {
+    this(metadataFileLocation, io, null);
+  }
+
+

Review comment:
       nit: extra line

##########
File path: core/src/main/java/org/apache/iceberg/StaticTableOperations.java
##########
@@ -31,15 +31,23 @@
 public class StaticTableOperations implements TableOperations {
   private final TableMetadata staticMetadata;
   private final FileIO io;
+  private final LocationProvider locationProvider;
 
   /**
    * Creates a StaticTableOperations tied to a specific static version of the TableMetadata
    */
   public StaticTableOperations(String metadataFileLocation, FileIO io) {
+    this(metadataFileLocation, io, null);
+  }
+
+
+  public StaticTableOperations(String metadataFileLocation, FileIO io, LocationProvider locationProvider) {
     this.io = io;
     this.staticMetadata = TableMetadataParser.read(io, metadataFileLocation);
+    this.locationProvider = locationProvider;
   }
 
+

Review comment:
       nit: extra line




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org