You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/08 19:52:53 UTC
[GitHub] [flink] AHeise opened a new pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
AHeise opened a new pull request #14596:
URL: https://github.com/apache/flink/pull/14596
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
}, {
"hash" : "6bf0b42350250a28034e192351f9216cd74573f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833",
"triggerID" : "6bf0b42350250a28034e192351f9216cd74573f7",
"triggerType" : "PUSH"
}, {
"hash" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11849",
"triggerID" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"triggerType" : "PUSH"
}, {
"hash" : "d3de7eedadb66e4f656777239b32a5db9fa48a34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11850",
"triggerID" : "d3de7eedadb66e4f656777239b32a5db9fa48a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* 8e8f2da721ac7d665ebe2f3af220553a366fb77a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11849)
* d3de7eedadb66e4f656777239b32a5db9fa48a34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
}, {
"hash" : "6bf0b42350250a28034e192351f9216cd74573f7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833",
"triggerID" : "6bf0b42350250a28034e192351f9216cd74573f7",
"triggerType" : "PUSH"
}, {
"hash" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11849",
"triggerID" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"triggerType" : "PUSH"
}, {
"hash" : "d3de7eedadb66e4f656777239b32a5db9fa48a34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11850",
"triggerID" : "d3de7eedadb66e4f656777239b32a5db9fa48a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* 6bf0b42350250a28034e192351f9216cd74573f7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833)
* 8e8f2da721ac7d665ebe2f3af220553a366fb77a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11849)
* d3de7eedadb66e4f656777239b32a5db9fa48a34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d763d693d0a2e7883b5ff513d35d619678f848c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826)
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* ba7133208896f696393fa2c975e3d739fab56a2b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830)
* f45a8472d9e5c70c4a54c87835426deb6dbacc4f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
}, {
"hash" : "6bf0b42350250a28034e192351f9216cd74573f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833",
"triggerID" : "6bf0b42350250a28034e192351f9216cd74573f7",
"triggerType" : "PUSH"
}, {
"hash" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11849",
"triggerID" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"triggerType" : "PUSH"
}, {
"hash" : "d3de7eedadb66e4f656777239b32a5db9fa48a34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11850",
"triggerID" : "d3de7eedadb66e4f656777239b32a5db9fa48a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3de7eedadb66e4f656777239b32a5db9fa48a34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
}, {
"hash" : "6bf0b42350250a28034e192351f9216cd74573f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833",
"triggerID" : "6bf0b42350250a28034e192351f9216cd74573f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* ba7133208896f696393fa2c975e3d739fab56a2b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830)
* f45a8472d9e5c70c4a54c87835426deb6dbacc4f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831)
* 6bf0b42350250a28034e192351f9216cd74573f7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d763d693d0a2e7883b5ff513d35d619678f848c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
}, {
"hash" : "6bf0b42350250a28034e192351f9216cd74573f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833",
"triggerID" : "6bf0b42350250a28034e192351f9216cd74573f7",
"triggerType" : "PUSH"
}, {
"hash" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11849",
"triggerID" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"triggerType" : "PUSH"
}, {
"hash" : "d3de7eedadb66e4f656777239b32a5db9fa48a34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11850",
"triggerID" : "d3de7eedadb66e4f656777239b32a5db9fa48a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* d3de7eedadb66e4f656777239b32a5db9fa48a34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
}, {
"hash" : "6bf0b42350250a28034e192351f9216cd74573f7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf0b42350250a28034e192351f9216cd74573f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* ba7133208896f696393fa2c975e3d739fab56a2b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830)
* f45a8472d9e5c70c4a54c87835426deb6dbacc4f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831)
* 6bf0b42350250a28034e192351f9216cd74573f7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756962717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756962717
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8d763d693d0a2e7883b5ff513d35d619678f848c (Fri Jan 08 19:55:16 UTC 2021)
**Warnings:**
* **8 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* ba7133208896f696393fa2c975e3d739fab56a2b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830)
* f45a8472d9e5c70c4a54c87835426deb6dbacc4f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d763d693d0a2e7883b5ff513d35d619678f848c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
}, {
"hash" : "6bf0b42350250a28034e192351f9216cd74573f7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833",
"triggerID" : "6bf0b42350250a28034e192351f9216cd74573f7",
"triggerType" : "PUSH"
}, {
"hash" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11849",
"triggerID" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* 6bf0b42350250a28034e192351f9216cd74573f7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833)
* 8e8f2da721ac7d665ebe2f3af220553a366fb77a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11849)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
}, {
"hash" : "6bf0b42350250a28034e192351f9216cd74573f7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833",
"triggerID" : "6bf0b42350250a28034e192351f9216cd74573f7",
"triggerType" : "PUSH"
}, {
"hash" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11849",
"triggerID" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"triggerType" : "PUSH"
}, {
"hash" : "d3de7eedadb66e4f656777239b32a5db9fa48a34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d3de7eedadb66e4f656777239b32a5db9fa48a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* 6bf0b42350250a28034e192351f9216cd74573f7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833)
* 8e8f2da721ac7d665ebe2f3af220553a366fb77a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11849)
* d3de7eedadb66e4f656777239b32a5db9fa48a34 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d763d693d0a2e7883b5ff513d35d619678f848c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826)
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* ba7133208896f696393fa2c975e3d739fab56a2b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #14596:
URL: https://github.com/apache/flink/pull/14596#discussion_r555281497
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ClientUtilsTest.java
##########
@@ -26,8 +26,15 @@
import org.apache.flink.util.SerializedThrowable;
import org.apache.flink.util.TestLogger;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Assertions;
+import static org.junit.jupiter.api.Assertions.*;
+import org.junit.jupiter.api.Timeout;
+import static org.hamcrest.MatcherAssert.assertThat;
+import org.junit.jupiter.api.Assertions;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import org.hamcrest.MatcherAssert;
+import static org.junit.jupiter.api.Assertions.assertTrue;
Review comment:
Yes, I was experimenting with changing most code with some generic replaces and do a final cleanup with spotless. Note that this PR is still very WIP - I just needed more AZP power.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
}, {
"hash" : "6bf0b42350250a28034e192351f9216cd74573f7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833",
"triggerID" : "6bf0b42350250a28034e192351f9216cd74573f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* 6bf0b42350250a28034e192351f9216cd74573f7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* ba7133208896f696393fa2c975e3d739fab56a2b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830)
* f45a8472d9e5c70c4a54c87835426deb6dbacc4f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756962717
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d3de7eedadb66e4f656777239b32a5db9fa48a34 (Fri May 28 07:05:47 UTC 2021)
**Warnings:**
* **7 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
}, {
"hash" : "6bf0b42350250a28034e192351f9216cd74573f7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833",
"triggerID" : "6bf0b42350250a28034e192351f9216cd74573f7",
"triggerType" : "PUSH"
}, {
"hash" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8e8f2da721ac7d665ebe2f3af220553a366fb77a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* 6bf0b42350250a28034e192351f9216cd74573f7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833)
* 8e8f2da721ac7d665ebe2f3af220553a366fb77a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d763d693d0a2e7883b5ff513d35d619678f848c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826)
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14596:
URL: https://github.com/apache/flink/pull/14596#discussion_r555132252
##########
File path: flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
##########
@@ -521,11 +525,11 @@ public void testCassandraTableSink() throws Exception {
cmp.setField(0, o.getString(0));
cmp.setField(1, o.getInt(2));
cmp.setField(2, o.getInt(1));
- Assert.assertTrue(
+ Assertions.assertTrue(
Review comment:
I'm wondering whether may want to think about doing something stupid and add a `public class Assert extends Assertions{}`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14596:
URL: https://github.com/apache/flink/pull/14596#discussion_r555128994
##########
File path: flink-clients/src/test/java/org/apache/flink/client/ClientUtilsTest.java
##########
@@ -26,8 +26,15 @@
import org.apache.flink.util.SerializedThrowable;
import org.apache.flink.util.TestLogger;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Assertions;
+import static org.junit.jupiter.api.Assertions.*;
+import org.junit.jupiter.api.Timeout;
+import static org.hamcrest.MatcherAssert.assertThat;
+import org.junit.jupiter.api.Assertions;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import org.hamcrest.MatcherAssert;
+import static org.junit.jupiter.api.Assertions.assertTrue;
Review comment:
are all these imports actually necessary or was it some quick-and-dirty approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14596:
URL: https://github.com/apache/flink/pull/14596#issuecomment-756974332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11826",
"triggerID" : "8d763d693d0a2e7883b5ff513d35d619678f848c",
"triggerType" : "PUSH"
}, {
"hash" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00cf97919f929c71d6efd01705f0d4057c0dd531",
"triggerType" : "PUSH"
}, {
"hash" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11830",
"triggerID" : "ba7133208896f696393fa2c975e3d739fab56a2b",
"triggerType" : "PUSH"
}, {
"hash" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831",
"triggerID" : "f45a8472d9e5c70c4a54c87835426deb6dbacc4f",
"triggerType" : "PUSH"
}, {
"hash" : "6bf0b42350250a28034e192351f9216cd74573f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833",
"triggerID" : "6bf0b42350250a28034e192351f9216cd74573f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00cf97919f929c71d6efd01705f0d4057c0dd531 UNKNOWN
* f45a8472d9e5c70c4a54c87835426deb6dbacc4f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11831)
* 6bf0b42350250a28034e192351f9216cd74573f7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11833)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #14596: [junit5-poc][tests] Use vintage runner instead of JUnit4.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #14596:
URL: https://github.com/apache/flink/pull/14596#discussion_r555281940
##########
File path: flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
##########
@@ -521,11 +525,11 @@ public void testCassandraTableSink() throws Exception {
cmp.setField(0, o.getString(0));
cmp.setField(1, o.getInt(2));
cmp.setField(2, o.getInt(1));
- Assert.assertTrue(
+ Assertions.assertTrue(
Review comment:
Yes that was also my thought. At the very least it would be convenient to have for changing the asserts themselves (the optional message moved to the last param which is a nightmare to grep/replace).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org