You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/03/26 09:22:14 UTC
Review Request 32527: LENS-449 : Fix JoinResolver skipping some
tables while pruning
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32527/
-----------------------------------------------------------
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Bugs: LENS-449
https://issues.apache.org/jira/browse/LENS-449
Repository: lens
Description
-------
Fix was to remove a unnecessary break in the loop.
Added unit test which reproduced the issue
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java ae7886b
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 4888ae1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java df594bd
Diff: https://reviews.apache.org/r/32527/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.068s]
[INFO] Lens .............................................. SUCCESS [1.669s]
[INFO] Lens API .......................................... SUCCESS [5.385s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.175s]
[INFO] Lens Cube ......................................... SUCCESS [2:04.681s]
[INFO] Lens DB storage ................................... SUCCESS [10.520s]
[INFO] Lens Query Library ................................ SUCCESS [4.476s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:31.783s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.927s]
[INFO] Lens Server ....................................... SUCCESS [4:27.255s]
[INFO] Lens client ....................................... SUCCESS [21.643s]
[INFO] Lens CLI .......................................... SUCCESS [2:52.780s]
[INFO] Lens Examples ..................................... SUCCESS [0.774s]
[INFO] Lens Distribution ................................. SUCCESS [9.329s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:04.774s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.413s]
[INFO] Lens Regression ................................... SUCCESS [0.481s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:26.178s
[INFO] Finished at: Thu Mar 26 08:21:29 UTC 2015
[INFO] Final Memory: 108M/1207M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 32527: LENS-449 : Fix JoinResolver skipping some
tables while pruning
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32527/#review77887
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On March 26, 2015, 1:52 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32527/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 1:52 p.m.)
>
>
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
>
>
> Bugs: LENS-449
> https://issues.apache.org/jira/browse/LENS-449
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fix was to remove a unnecessary break in the loop.
> Added unit test which reproduced the issue
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java ae7886b
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 4888ae1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java df594bd
>
> Diff: https://reviews.apache.org/r/32527/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.068s]
> [INFO] Lens .............................................. SUCCESS [1.669s]
> [INFO] Lens API .......................................... SUCCESS [5.385s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.175s]
> [INFO] Lens Cube ......................................... SUCCESS [2:04.681s]
> [INFO] Lens DB storage ................................... SUCCESS [10.520s]
> [INFO] Lens Query Library ................................ SUCCESS [4.476s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:31.783s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.927s]
> [INFO] Lens Server ....................................... SUCCESS [4:27.255s]
> [INFO] Lens client ....................................... SUCCESS [21.643s]
> [INFO] Lens CLI .......................................... SUCCESS [2:52.780s]
> [INFO] Lens Examples ..................................... SUCCESS [0.774s]
> [INFO] Lens Distribution ................................. SUCCESS [9.329s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:04.774s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.413s]
> [INFO] Lens Regression ................................... SUCCESS [0.481s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:26.178s
> [INFO] Finished at: Thu Mar 26 08:21:29 UTC 2015
> [INFO] Final Memory: 108M/1207M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>