You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/09/05 19:52:30 UTC
[jira] [Commented] (COUCHDB-2302) Unable to create new config
sections
[ https://issues.apache.org/jira/browse/COUCHDB-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123244#comment-14123244 ]
ASF GitHub Bot commented on COUCHDB-2302:
-----------------------------------------
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/54
COUCHDB-2302: Allow creation of new sections in config view
COUCHDB-2302: Allow creation of new sections in config view
I added a bunch of tests and moved one method from the view to the collection.
I also removed some unused properties, like `this.error` and separated the event-handler from the logic to make the code testable.
Split in multiple logical commits as I first added tests, then refactored and then fixed the actual bug.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton COUCHDB-2302--config-sections
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit e792b5054650116d7c969faf40c1705274cbd469
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-09-05T16:48:58Z
Config: Set Modal under tests
commit f41c0c9de56172bf36efbe7d49a6443edb60909b
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-09-05T17:03:09Z
Config: refactor: move method to collection
commit 8de3af263ad1744ca6c847919f3fbf1a262b654a
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-09-05T17:15:55Z
Config: remove unused this.error
commit 1114c9d03e1d21190077d0e3ad4ba542184bf6c6
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-09-05T17:46:12Z
Config: allow creation of new sections
closes COUCHDB-2302
----
> Unable to create new config sections
> ------------------------------------
>
> Key: COUCHDB-2302
> URL: https://issues.apache.org/jira/browse/COUCHDB-2302
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Fauxton
> Reporter: Alexander Shorin
> Assignee: Robert Kowalski
>
> Fauxton strongly requires to create new config options for the exited config sections. That's makes you unable to add new query server, configure CORs, OAuth, OS Daemons and other features which doesn't has own section by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)