[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #582: DISPATCH-1440 - Deprecated passwordFile attribute in sslProfile and m…

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #582: DISPATCH-1440 - Deprecated passwordFile attribute in sslProfile and m…
URL: https://github.com/apache/qpid-dispatch/pull/582#discussion_r332156779
 
 

 ##########
 File path: src/connection_manager.c
 ##########
 @@ -103,6 +103,38 @@ static qd_config_ssl_profile_t *qd_find_ssl_profile(qd_connection_manager_t *cm,
     return 0;
 }
 
+/**
+ * Read the file from the password_file location on the file system and populate password_field with the
+ * contents of the file.
+ */
+static void qd_set_password_from_file(char *password_file, char **password_field)
+{
+    if (password_file) {
+        FILE *file = fopen(password_file, "r");
 
 Review comment:
   What happens when the fopen fails, like read permission or file not found?
   This looks as if we fail silently.   We need a log error here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org