You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/23 06:04:41 UTC

[GitHub] [hudi] vinothchandar commented on a change in pull request #1567: [HUDI-840]Clean blank file created by HoodieLogFormatWriter

vinothchandar commented on a change in pull request #1567:
URL: https://github.com/apache/hudi/pull/1567#discussion_r459230495



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java
##########
@@ -210,6 +210,14 @@ public void close() throws IOException {
     flush();
     output.close();
     output = null;
+    Path path = logFile.getPath();

Review comment:
       fair enough. but this is effectively doing an extra RPC every close, just to handle this corner case. what is the actual  issue caused by the empty file? does the query/writing fail or get stuck?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org