[GitHub] dongjoon-hyun commented on a change in pull request #23530: [SPARK-26576][SQL] Broadcast hint not applied to partitioned table

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #23530: [SPARK-26576][SQL] Broadcast hint not applied to partitioned table
URL: https://github.com/apache/spark/pull/23530#discussion_r247332753
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
 ##########
 @@ -68,9 +68,6 @@ object PhysicalOperation extends PredicateHelper {
         val substitutedCondition = substitute(aliases)(condition)
         (fields, filters ++ splitConjunctivePredicates(substitutedCondition), other, aliases)
 
-      case h: ResolvedHint =>
-        collectProjectsAndFilters(h.child)
-
 
 Review comment:
   Hi, @jzhuge .
   Do we need this? According to the previous PR, `master` has no issue. So, I expected a test only PR.
   
   cc @cloud-fan and @gatorsmile 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org