You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by seanparsons <gi...@git.apache.org> on 2014/11/17 20:34:38 UTC

[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...

GitHub user seanparsons opened a pull request:

    https://github.com/apache/thrift/pull/272

    Fixed the path to the LICENSE file for Haskell lib.

    This fixes the path to the LICENSE file for the Haskell library so that it doesn't break when pulling it down from Hackage, currently this means the 0.9.2 release is unusable as a result of this.
    
    In changing the path I've confirmed that the LICENSE file is included as the path being incorrect also resulted in the file not being included in the tarball.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/seanparsons/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/272.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #272
    
----
commit aa11bcb28cdfe6614833c5c122b17021af4af2b9
Author: Sean Parsons <gi...@futurenotfound.com>
Date:   2014-11-17T19:23:43Z

    Realigned the path to the LICENSE file for Haskell cabal build file.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...

Posted by seanparsons <gi...@git.apache.org>.
Github user seanparsons commented on the pull request:

    https://github.com/apache/thrift/pull/272#issuecomment-64076498
  
    The sooner the better, mostly because it's just completely broken as it is, I was wondering if a 0.9.2-1 release would be possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...

Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell closed the pull request at:

    https://github.com/apache/thrift/pull/272


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...

Posted by igillis <gi...@git.apache.org>.
Github user igillis commented on the pull request:

    https://github.com/apache/thrift/pull/272#issuecomment-63592969
  
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...

Posted by igillis <gi...@git.apache.org>.
Github user igillis commented on the pull request:

    https://github.com/apache/thrift/pull/272#issuecomment-63561945
  
    I ran into this last night -- thanks for fixing @seanparsons!
    
    I'm new to the Haskell/Thrift ecosystem -- will this fix be picked up by hackage or do I need to download the corresponding tarball from jenkins?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...

Posted by seanparsons <gi...@git.apache.org>.
Github user seanparsons commented on the pull request:

    https://github.com/apache/thrift/pull/272#issuecomment-63438188
  
    The JIRA for this pull request is thus: https://issues.apache.org/jira/browse/THRIFT-2840


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...

Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:

    https://github.com/apache/thrift/pull/272#issuecomment-63583220
  
    This will be picked up in the 0.9.3 release slated for early next month


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---