[GitHub] [pulsar] codelipenghui commented on a diff in pull request #15099: [cleanup][broker] PIP 45: Deprecate zookeeper settings

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #15099:
URL: https://github.com/apache/pulsar/pull/15099#discussion_r848127460


##########
conf/broker.conf:
##########
@@ -1434,3 +1434,9 @@ tlsEnabled=false
 # Enable Key_Shared subscription (default is enabled)
 # @deprecated since 2.8.0 subscriptionTypesEnabled is preferred over subscriptionKeySharedEnable.
 subscriptionKeySharedEnable=true
+
+# Max number of "acknowledgment holes" that can be stored in Zookeeper. If number of unack message range is higher
+# than this limit then broker will persist unacked ranges into bookkeeper to avoid additional data overhead into
+# zookeeper.
+# Deprecated: use managedLedgerMaxUnackedRangesToPersistInMetadataStore
+managedLedgerMaxUnackedRangesToPersistInZooKeeper=1000

Review Comment:
   You can change the default value of the deprecated to `-1`
   and then check if users changed `-1` to other values, we should apply this one.
   
   A related PR https://github.com/apache/pulsar/pull/14147/files#diff-cc761e782083f37db72cd91684fee07b931c188dd93333397c62b0a4c45a657eR2671-R2681



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org