You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ian Boston <ie...@tfd.co.uk> on 2008/08/27 17:48:38 UTC
Find Bugs Annotations
Can I use Findbugs annotations in Shindig.
the jar is at http://repo1.maven.org/maven2/findbugs/annotations/1.0.0/
Its only needed for Compile and Reporting and enables the supression
of false positives in
http://people.apache.org/~ieb/shindig/shindig-parent/shindig-social-
api/findbugs.html#org.apache.shindig.social.core.util.BeanJsonConverter
with a
@edu.umd.cs.findbugs.annotations.SuppressWarnings
("DM_CONVERT_CASE","The field is part of the OS spec and not i18n");
Looking at other apache projects MyFaces is using Findbugs
and I think Hadoop uses both FindBugs and annotations.
The reason for my question is that its LGPL as is the findbugs maven
plugin.
Ian
Re: Find Bugs Annotations
Posted by Kevin Brown <et...@google.com>.
Shouldn't the warning have done that? :-p
On Wed, Aug 27, 2008 at 10:56 AM, Ian Boston <ie...@tfd.co.uk> wrote:
> Yup,
> That should encourage us to fix the findbug rather than suppress the
> warning
> :)
>
>
> On 27 Aug 2008, at 18:43, Kevin Brown wrote:
>
> That sure is an ugly annotation, though.
>>
>
>
Re: Find Bugs Annotations
Posted by Ian Boston <ie...@tfd.co.uk>.
Yup,
That should encourage us to fix the findbug rather than suppress the
warning
:)
On 27 Aug 2008, at 18:43, Kevin Brown wrote:
> That sure is an ugly annotation, though.
Re: Find Bugs Annotations
Posted by Kevin Brown <et...@google.com>.
The rentention policy is CLASS, so no runtime dependency should be needed.
That sure is an ugly annotation, though.
On Wed, Aug 27, 2008 at 10:17 AM, Ian Boston <ie...@tfd.co.uk> wrote:
> Ok, Its a supposed to be a compile time only dependency, but I will check
> that its not required at runtime and doesn't cause a classnotfound by virtue
> of being in the imports or annotations on the class.
>
> I will also see if I can check that it doesn't become a dependency when
> using any of the jars.
> Ian
>
>
> On 27 Aug 2008, at 17:26, Chris Chabot wrote:
>
> Snippet from:
>> http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200604.mbox/%
>> 3C9186D1D624F88F469BE0CC4F2DDB970B774BE4@repbex02.amer.bea.com%3E
>>
>> "In the simplest case, this means that a licensor who includes code it
>> obtained
>> under an LGPL in a project that it licenses to others under an ASF 2.0
>> license, *most likely* (lawyer hedge; if you buy my analysis of the
>> incompatibility of ASF 2.0 and LGPL on an earlier thread) is
>> distributing the LGPL-encumbered parts in violation of the LGPL and in
>> breach of the authors' Copyright in those LGPL-covered portions."
>>
>> I think that means it would be Ok to link against it, but not distribute
>> it as part of Shindig (insert standard IANAL disclaimer here).
>>
>> So if it's a lib that maven can pull in for you, go ahead, if it's
>> something where you would have to add some LGPL licensed source to Shindig,
>> that's a no-go.
>>
>> -- Chris
>>
>>
>> On Aug 27, 2008, at 6:09 PM, Cassie wrote:
>>
>> I have no idea if we are legally allowed to depend on findbugs - if
>>> someone
>>> else says that is okay though that the annotations sound fine to me.
>>>
>>> - Cassie
>>>
>>>
>>> On Wed, Aug 27, 2008 at 8:48 AM, Ian Boston <ie...@tfd.co.uk> wrote:
>>>
>>> Can I use Findbugs annotations in Shindig.
>>>>
>>>> the jar is at http://repo1.maven.org/maven2/findbugs/annotations/1.0.0/
>>>>
>>>> Its only needed for Compile and Reporting and enables the supression of
>>>> false positives in
>>>> http://people.apache.org/~ieb/shindig/shindig-parent/shindig-<http://people.apache.org/%7Eieb/shindig/shindig-parent/shindig->
>>>> social-<http://people.apache.org/%7Eieb/shindig/shindig-parent/
>>>> shindig-social->
>>>> api/findbugs.html#org.apache.shindig.social.core.util.BeanJsonConverter
>>>>
>>>> with a
>>>> @edu.umd.cs.findbugs.annotations.SuppressWarnings("DM_CONVERT_CASE","The
>>>> field is part of the OS spec and not i18n");
>>>>
>>>> Looking at other apache projects MyFaces is using Findbugs
>>>> and I think Hadoop uses both FindBugs and annotations.
>>>>
>>>> The reason for my question is that its LGPL as is the findbugs maven
>>>> plugin.
>>>>
>>>> Ian
>>>>
>>>>
>>>>
>>>>
>>
>
Re: Find Bugs Annotations
Posted by Ian Boston <ie...@tfd.co.uk>.
Ok, Its a supposed to be a compile time only dependency, but I will
check that its not required at runtime and doesn't cause a
classnotfound by virtue of being in the imports or annotations on the
class.
I will also see if I can check that it doesn't become a dependency
when using any of the jars.
Ian
On 27 Aug 2008, at 17:26, Chris Chabot wrote:
> Snippet from:
> http://mail-archives.apache.org/mod_mbox/www-legal-discuss/
> 200604.mbox/%
> 3C9186D1D624F88F469BE0CC4F2DDB970B774BE4@repbex02.amer.bea.com%3E
>
> "In the simplest case, this means that a licensor who includes code
> it obtained
> under an LGPL in a project that it licenses to others under an ASF 2.0
> license, *most likely* (lawyer hedge; if you buy my analysis of the
> incompatibility of ASF 2.0 and LGPL on an earlier thread) is
> distributing the LGPL-encumbered parts in violation of the LGPL and in
> breach of the authors' Copyright in those LGPL-covered portions."
>
> I think that means it would be Ok to link against it, but not
> distribute it as part of Shindig (insert standard IANAL disclaimer
> here).
>
> So if it's a lib that maven can pull in for you, go ahead, if it's
> something where you would have to add some LGPL licensed source to
> Shindig, that's a no-go.
>
> -- Chris
>
>
> On Aug 27, 2008, at 6:09 PM, Cassie wrote:
>
>> I have no idea if we are legally allowed to depend on findbugs -
>> if someone
>> else says that is okay though that the annotations sound fine to me.
>>
>> - Cassie
>>
>>
>> On Wed, Aug 27, 2008 at 8:48 AM, Ian Boston <ie...@tfd.co.uk> wrote:
>>
>>> Can I use Findbugs annotations in Shindig.
>>>
>>> the jar is at http://repo1.maven.org/maven2/findbugs/annotations/
>>> 1.0.0/
>>>
>>> Its only needed for Compile and Reporting and enables the
>>> supression of
>>> false positives in
>>> http://people.apache.org/~ieb/shindig/shindig-parent/shindig-
>>> social-<http://people.apache.org/%7Eieb/shindig/shindig-parent/
>>> shindig-social->
>>> api/
>>> findbugs.html#org.apache.shindig.social.core.util.BeanJsonConverter
>>>
>>> with a
>>> @edu.umd.cs.findbugs.annotations.SuppressWarnings
>>> ("DM_CONVERT_CASE","The
>>> field is part of the OS spec and not i18n");
>>>
>>> Looking at other apache projects MyFaces is using Findbugs
>>> and I think Hadoop uses both FindBugs and annotations.
>>>
>>> The reason for my question is that its LGPL as is the findbugs maven
>>> plugin.
>>>
>>> Ian
>>>
>>>
>>>
>
Re: Find Bugs Annotations
Posted by Chris Chabot <ch...@xs4all.nl>.
Snippet from:
http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200604.mbox/%3C9186D1D624F88F469BE0CC4F2DDB970B774BE4@repbex02.amer.bea.com%3E
"In the simplest case, this means that a licensor who includes code it
obtained
under an LGPL in a project that it licenses to others under an ASF 2.0
license, *most likely* (lawyer hedge; if you buy my analysis of the
incompatibility of ASF 2.0 and LGPL on an earlier thread) is
distributing the LGPL-encumbered parts in violation of the LGPL and in
breach of the authors' Copyright in those LGPL-covered portions."
I think that means it would be Ok to link against it, but not
distribute it as part of Shindig (insert standard IANAL disclaimer
here).
So if it's a lib that maven can pull in for you, go ahead, if it's
something where you would have to add some LGPL licensed source to
Shindig, that's a no-go.
-- Chris
On Aug 27, 2008, at 6:09 PM, Cassie wrote:
> I have no idea if we are legally allowed to depend on findbugs - if
> someone
> else says that is okay though that the annotations sound fine to me.
>
> - Cassie
>
>
> On Wed, Aug 27, 2008 at 8:48 AM, Ian Boston <ie...@tfd.co.uk> wrote:
>
>> Can I use Findbugs annotations in Shindig.
>>
>> the jar is at http://repo1.maven.org/maven2/findbugs/annotations/1.0.0/
>>
>> Its only needed for Compile and Reporting and enables the
>> supression of
>> false positives in
>> http://people.apache.org/~ieb/shindig/shindig-parent/shindig-social-
>> <http://people.apache.org/%7Eieb/shindig/shindig-parent/shindig-social-
>> >
>> api/
>> findbugs.html#org.apache.shindig.social.core.util.BeanJsonConverter
>>
>> with a
>> @edu
>> .umd.cs.findbugs.annotations.SuppressWarnings("DM_CONVERT_CASE","The
>> field is part of the OS spec and not i18n");
>>
>> Looking at other apache projects MyFaces is using Findbugs
>> and I think Hadoop uses both FindBugs and annotations.
>>
>> The reason for my question is that its LGPL as is the findbugs maven
>> plugin.
>>
>> Ian
>>
>>
>>
Re: Find Bugs Annotations
Posted by Cassie <do...@apache.org>.
I have no idea if we are legally allowed to depend on findbugs - if someone
else says that is okay though that the annotations sound fine to me.
- Cassie
On Wed, Aug 27, 2008 at 8:48 AM, Ian Boston <ie...@tfd.co.uk> wrote:
> Can I use Findbugs annotations in Shindig.
>
> the jar is at http://repo1.maven.org/maven2/findbugs/annotations/1.0.0/
>
> Its only needed for Compile and Reporting and enables the supression of
> false positives in
> http://people.apache.org/~ieb/shindig/shindig-parent/shindig-social-<http://people.apache.org/%7Eieb/shindig/shindig-parent/shindig-social->
> api/findbugs.html#org.apache.shindig.social.core.util.BeanJsonConverter
>
> with a
> @edu.umd.cs.findbugs.annotations.SuppressWarnings("DM_CONVERT_CASE","The
> field is part of the OS spec and not i18n");
>
> Looking at other apache projects MyFaces is using Findbugs
> and I think Hadoop uses both FindBugs and annotations.
>
> The reason for my question is that its LGPL as is the findbugs maven
> plugin.
>
> Ian
>
>
>