[jira] [Commented] (SLING-7194) Document that AdapterManager sorts AdapterFactory implementations lowest ranking first

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287522#comment-16287522 ] 

ASF GitHub Bot commented on SLING-7194:
---------------------------------------

stefanseifert closed pull request #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first
URL: https://github.com/apache/sling-org-apache-sling-adapter/pull/1
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Document that AdapterManager sorts AdapterFactory implementations lowest ranking first
> --------------------------------------------------------------------------------------
>
>                 Key: SLING-7194
>                 URL: https://issues.apache.org/jira/browse/SLING-7194
>             Project: Sling
>          Issue Type: Task
>          Components: Extensions
>    Affects Versions: API 2.16.4
>            Reporter: Stefan Seifert
>            Assignee: Stefan Seifert
>            Priority: Minor
>             Fix For: API 2.16.6
>
>
> the current implementation of AdapterManager uses a AdapterFactoryDescriptorMap to sort the AdapterFactory implementations found.
> this is done using a TreeMap with the ServiceReference as key. ServiceReference implements a compareTo.
> according to its documentation the default implementation sorts with service-ranking lowest-first/service id highest-first:
> https://osgi.org/javadoc/r6/core/org/osgi/framework/ServiceReference.html#compareTo(java.lang.Object)
> when picking a service from multiple ones using BundleContext.getService, the service with hightest service ranking/lowest service id is returned.
> i would expect the same from the AdapterManager implementation - if multiple implementations match pick that one with highest ranking/lowest service id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)