[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

["cmccabe (via GitHub)" <gi...@apache.org>]

cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1163287276


##########
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##########
@@ -266,6 +311,11 @@ private ApiError updateMetadataVersion(
             new FeatureLevelRecord()
                 .setName(MetadataVersion.FEATURE_NAME)
                 .setFeatureLevel(newVersionLevel), FEATURE_LEVEL_RECORD.lowestSupportedVersion()));
+
+        // If we are moving to a version that supports migrations, we need to write the correct state into the log

Review Comment:
   I don't see why this is needed. If we're coming from IBP_3_3_IV3 or earlier, the only valid value is NONE. And omitting the record just means that its value is implictly assumed to be equal to NONE. So there's nothing to do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org