[jira] Commented: (SCXML-64) datamodel should not be allowed in transition.

["Ross Yakulis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCXML-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555722#action_12555722 ] 

Ross Yakulis commented on SCXML-64:
-----------------------------------

Sorry, you are correct about the rules.  Not sure what I saw but the
rules are right, probably
rushing to wrap things up before the holidays.

But it seems to me that instead of ignoring the misplaced <datamodel> an

error should be emitted in the digester as that is invalid.  There
should probably be 
some schema validation on the scxml document, before (or as) it is
digested.

Maybe this will fix things in a future release (from
SCXMLDIgester.java).

        //Uncomment next line after SCXML DTD is available
        //digester.setValidating(true);

My real complaint is that the out of place <datamodel> element should be
flagged as invalid when the document is being digested.

Ross




> datamodel should not be allowed in transition.
> ----------------------------------------------
>
>                 Key: SCXML-64
>                 URL: https://issues.apache.org/jira/browse/SCXML-64
>             Project: Commons SCXML
>          Issue Type: Bug
>    Affects Versions: 0.6
>         Environment: win xp, java 1.5
>            Reporter: Ross Yakulis
>            Priority: Minor
>         Attachments: fails.xml, TransitionBugTest.java, TransitionBugTestSuite.java, works.xml
>
>
>     <transition event="my.event" target="somewhere">
>         <datamodel>
> 	<data name="dummy" expr="somedata"/>
>         </datamodel>
>         <log expr="dummy" />
>         <log expr="'*****' + dummy" />
>       /transition>
> Given the above transition, the first log logs null, send log causes a nullpointerexception.  Acording to the SCXML spec datamodel is not allowed in a transition only globally and at the state level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.