[GitHub] [geode] mcmellawatt opened pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["mcmellawatt (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

It never applied to Geode.

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["moleske (GitHub)" <gi...@apache.org>]

On GitHub this doesn't render as list making reading it more challenging.  My understanding is that lettered lists are not valid markdown.  I might suggest using either unordered lists, numbers, or using html (since that is all markdown is anyway)

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["mcmellawatt (GitHub)" <gi...@apache.org>]

I'll fix this, thanks

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["mcmellawatt (GitHub)" <gi...@apache.org>]

Missed that one, will clean it up

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["kirklund (GitHub)" <gi...@apache.org>]

You should remove any mention of "closed"

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] davebarnes97 commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["davebarnes97 (GitHub)" <gi...@apache.org>]

In this case, stick with an ordered list. A set of nested numbers will be OK.

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["mcmellawatt (GitHub)" <gi...@apache.org>]

Good to know - was this deprecated as part of the recent build changes?  Will fix.

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["moleske (GitHub)" <gi...@apache.org>]

This is a very Mac specific command, not sure that's what you intended

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on issue #2456: Adding IntelliJ setup instructions to BUILDING.md

["mcmellawatt (GitHub)" <gi...@apache.org>]

Made all the requested changes - thanks for all the feedback!

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["mcmellawatt (GitHub)" <gi...@apache.org>]

Ack yeah this is now 2-5 with the last set of changes.  Will fix, thanks!

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

I am missing the referenced b-e above?

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["kirklund (GitHub)" <gi...@apache.org>]

You should remove any mention of "closed" or "open"

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt closed pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["mcmellawatt (GitHub)" <gi...@apache.org>]

[ pull request closed by mcmellawatt ]

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["mcmellawatt (GitHub)" <gi...@apache.org>]

Thanks, I'll clean that up

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

This step is not required as there is no such variable in the gradle build.

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] davebarnes97 commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["davebarnes97 (GitHub)" <gi...@apache.org>]

In this case, the nested list could be unordered.

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["mcmellawatt (GitHub)" <gi...@apache.org>]

Thanks Dave, that's what I settled on as well.  See my latest commit.

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2456: Adding IntelliJ setup instructions to BUILDING.md

["mcmellawatt (GitHub)" <gi...@apache.org>]

Missed the list formatting on this one, will fix.  Thanks Dave.

[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org