[GitHub] [metamodel] kaspersorensen commented on a change in pull request #211: METAMODEL-1207: fix regex pattern in order to fetch the correct version in all cases

[GitBox <gi...@apache.org>]

kaspersorensen commented on a change in pull request #211: METAMODEL-1207: fix regex pattern in order to fetch the correct version in all cases
URL: https://github.com/apache/metamodel/pull/211#discussion_r263098215
 
 

 ##########
 File path: jdbc/src/test/java/org/apache/metamodel/jdbc/dialects/OracleQueryRewriterTest.java
 ##########
 @@ -92,6 +92,14 @@ public void testOffsetFetchVersionCheck() throws SQLException {
         Assert.assertEquals("The query shouldn't be rewritten.", query.toSql(), qr.rewriteQuery(query));
     }
 
+    @Test
+    public void testOffsetFetchVersionSpecialCaseCheck() throws SQLException {
 
 Review comment:
   The test case here seems to rely on a number of other factors and as such I think the assertion is a bit of a by-product of the version parsing logic, not actually testing the parsing itself.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services