You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/05/02 06:26:20 UTC
[GitHub] [logging-log4j-kotlin] rocketraman opened a new pull request #17: Kotlin provided scope
rocketraman opened a new pull request #17:
URL: https://github.com/apache/logging-log4j-kotlin/pull/17
Following the discussion in https://github.com/apache/logging-log4j-kotlin/pull/14, I believe the best path forward is to make the Kotlin dependences "provided" dependencies, which should prevent downstream projects from pulling in older versions of Kotlin libs transitively.
However, see the first commit's message -- it scares me a bit because kotlin-reflect and possible the coroutines dependencies may not be on everyone's classpath, and this will cause a runtime failure. I'm not sure what the best approach is but opening this PR for discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] rocketraman edited a comment on pull request #17: Kotlin provided scope
Posted by GitBox <gi...@apache.org>.
rocketraman edited a comment on pull request #17:
URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830980096
@jvz No idea why CI is failing but its not limited to this branch. The other PRs I recently submitted failed with the same non-error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #17: Kotlin provided scope
Posted by GitBox <gi...@apache.org>.
rocketraman commented on pull request #17:
URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830834412
> Seems like a good idea. Are there CI updates needed here, though? Some build failure.
Weird I'm not seeing any errors in the build logs, just the abort at the end. Can we try to rebuild it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] rocketraman merged pull request #17: Kotlin provided scope
Posted by GitBox <gi...@apache.org>.
rocketraman merged pull request #17:
URL: https://github.com/apache/logging-log4j-kotlin/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] jvz commented on pull request #17: Kotlin provided scope
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #17:
URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-837368339
I'm not blocking you from merging this. Feel free :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] jvz commented on pull request #17: Kotlin provided scope
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #17:
URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830836699
If you don't have a "re-run" link on the GitHub Check, then try adding an empty commit or possibly closing then reopening the PR to retrigger CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] jvz commented on pull request #17: Kotlin provided scope
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #17:
URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830830676
Seems like a good idea. Are there CI updates needed here, though? Some build failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #17: Kotlin provided scope
Posted by GitBox <gi...@apache.org>.
rocketraman commented on pull request #17:
URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-837335446
@jvz Not sure what was up with the CI system before, but it seems to be working now. I added a couple of extra commits on this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #17: Kotlin provided scope
Posted by GitBox <gi...@apache.org>.
rocketraman commented on pull request #17:
URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830980096
@jvz No idea why CI is failing but its not limited to this branch. The other PRs I recently submitted failed with the same error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org